----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69341/#review210752 -----------------------------------------------------------
Mostly just questions about logging ql/src/java/org/apache/hadoop/hive/metastore/SynchronizedMetaStoreClient.java Lines 139 (patched) <https://reviews.apache.org/r/69341/#comment295503> nit: Might want to remove this extra line ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2087 (patched) <https://reviews.apache.org/r/69341/#comment295504> Does this really worth a change? I usually use this only if generating the log message is costly. The LOG.debug will definitely will start with the same check... ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2161 (patched) <https://reviews.apache.org/r/69341/#comment295502> Does this really worth a change? I usually use this only if generating the log message is costly. The LOG.debug will definitely will start with the same check... ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2211 (patched) <https://reviews.apache.org/r/69341/#comment295505> Does this really worth a change? I usually use this only if generating the log message is costly. The LOG.debug will definitely will start with the same check... ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2345 (patched) <https://reviews.apache.org/r/69341/#comment295508> Is the output readable with multiple partitions? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2659 (patched) <https://reviews.apache.org/r/69341/#comment295506> Does this really worth a change? I usually use this only if generating the log message is costly. The LOG.debug will definitely will start with the same check... ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2720 (patched) <https://reviews.apache.org/r/69341/#comment295507> Does this really worth a change? I usually use this only if generating the log message is costly. The LOG.debug will definitely will start with the same check... - Peter Vary On nov. 15, 2018, 8:52 de, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69341/ > ----------------------------------------------------------- > > (Updated nov. 15, 2018, 8:52 de) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-20891: Call alter_partition in batch when dynamically loading partitions > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/metastore/SynchronizedMetaStoreClient.java > e8f362357537e73502f743a9df189dec9be2da5d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > e185bf49d42da9d1497643c20bbd71edaf071bf1 > > > Diff: https://reviews.apache.org/r/69341/diff/1/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
