----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review210740 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java Line 165 (original), 165 (patched) <https://reviews.apache.org/r/69367/#comment295490> ? itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java Line 170 (original), 170 (patched) <https://reviews.apache.org/r/69367/#comment295491> why are all these test made non-tests? or does this do somethign else? ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java Lines 533 (patched) <https://reviews.apache.org/r/69367/#comment295492> were you going to do "0+validate_acid_sort_order(...)" instead? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java Lines 54 (patched) <https://reviews.apache.org/r/69367/#comment295494> I'm guessing if compareTo returns 0 that's bad - we should have unique row ids ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java Lines 61 (patched) <https://reviews.apache.org/r/69367/#comment295493> should this return 0? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java Lines 80 (patched) <https://reviews.apache.org/r/69367/#comment295489> I think comparison should include 'bucketProperty' since we sort on 'bucketProperty' not just bucketId. In particular, if you have > 1 statement per txn, we expect that rows from 2nd stmt follow those from 1st. - Eugene Koifman On Nov. 19, 2018, 3:49 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69367/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2018, 3:49 a.m.) > > > Review request for hive and Eugene Koifman. > > > Bugs: HIVE-20699 > https://issues.apache.org/jira/browse/HIVE-20699 > > > Repository: hive-git > > > Description > ------- > > https://jira.apache.org/jira/browse/HIVE-20699 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 65264f323f > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java > 40dd992455 > pom.xml 26b662e4c3 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 578b16cc7c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SplitGrouper.java 7f8bd229a6 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java > 8cabf960db > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 4d55592b63 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 6e7c78bd17 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 92c74e1d06 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69367/diff/2/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
