----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210362 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java Lines 350 (patched) <https://reviews.apache.org/r/69202/#comment295024> You do not need a list anymore, you can use the bitset and it is faster. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java Lines 351 (patched) <https://reviews.apache.org/r/69202/#comment295025> Same as above. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java Lines 356 (patched) <https://reviews.apache.org/r/69202/#comment295026> This would become originalGroupSet.nth(i) ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java Lines 357 (patched) <https://reviews.apache.org/r/69202/#comment295027> Instead of using contains here, you can use _get(int bitIndex)_. ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java Lines 358 (patched) <https://reviews.apache.org/r/69202/#comment295028> This would be currentKey.get(backtrackedCol) ql/src/test/queries/clientpositive/constraints_optimization.q Lines 355 (patched) <https://reviews.apache.org/r/69202/#comment295029> Can we add two more tests: - One with column swapping before GroupBy (probably if you use group by b,c,a and table contains a,b,c, it should work and add the Project in between the TS and the GroupBy). - One with a join and a group by on one column for other table that is also the join key of the table where all columns are coming from (as in the whiteboard). - Jesús Camacho Rodríguez On Nov. 7, 2018, 1:49 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69202/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2018, 1:49 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-20804 > https://issues.apache.org/jira/browse/HIVE-20804 > > > Repository: hive-git > > > Description > ------- > > See Jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java > 9aa30129b6 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelFieldTrimmer.java > b7c31bdfca > ql/src/test/queries/clientpositive/constraints_optimization.q 70ab8509c5 > ql/src/test/results/clientpositive/llap/constraints_optimization.q.out > 96caa4d6dd > > > Diff: https://reviews.apache.org/r/69202/diff/4/ > > > Testing > ------- > > > Thanks, > > Vineet Garg > >
