----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69107/ -----------------------------------------------------------
(Updated Oct. 31, 2018, 11:15 p.m.) Review request for hive, Antal Sinkovits, Sahil Takiar, and Vihang Karajgaonkar. Changes ------- Added change for threadfactory to have daemon threads. Addressed review comments. I am using shutDownNow instead of shutDown because we really do not need awaitTermination as shutDownNow will anyways interrupt the existing threads, and will not accept new tasks. For awaitTermination, the main thread has to wait for a fixed amount of time which I feel is not really useful here, as we are not executing any critical task, we do not care about the logger thread as we will anyways log final count and memory usage in close method. Repository: hive-git Description ------- Improve record and memory usage logging in SparkRecordHandler Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 88dd12c05ade417aca4cdaece4448d31d4e1d65f ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMergeFileRecordHandler.java 8880bb604e088755dcfb0bcb39689702fab0cb77 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java cb5bd7ada2d5ad4f1f654cf80ddaf4504be5d035 ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 20e7ea0f4e8d4ff79dddeaab0406fc7350d22bd7 Diff: https://reviews.apache.org/r/69107/diff/4/ Changes: https://reviews.apache.org/r/69107/diff/3-4/ Testing ------- Thanks, Bharathkrishna Guruvayoor Murali
