----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69054/#review209662 -----------------------------------------------------------
This all looks good, I just have annoying questions standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 290 (patched) <https://reviews.apache.org/r/69054/#comment294205> Can you use ConfVars.MANAGER_FACTORY_CLASS.getVarname() instead of the string? standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 291 (patched) <https://reviews.apache.org/r/69054/#comment294206> What is someone has set ConfVars.MANAGER_FACTORY_CLASS to some non-default value? Is this still correct? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 918 (patched) <https://reviews.apache.org/r/69054/#comment294201> Add comment expaining what the test does standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 923 (patched) <https://reviews.apache.org/r/69054/#comment294198> numThreads and numIterations seem small to me, can we make them higher without the test taking a long time? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 927 (patched) <https://reviews.apache.org/r/69054/#comment294199> ArrayList<>(numThreads) ? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 948 (patched) <https://reviews.apache.org/r/69054/#comment294197> nit: add a timeout to get then you will kow the test can never hang - Andrew Sherman On Oct. 16, 2018, 8:36 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69054/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2018, 8:36 p.m.) > > > Review request for hive, Andrew Sherman, Alan Gates, and Peter Vary. > > > Bugs: HIVE-20740 > https://issues.apache.org/jira/browse/HIVE-20740 > > > Repository: hive-git > > > Description > ------- > > HIVE-20740 : Remove global lock in ObjectStore.setConf method > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 66977d79c946f1ac57aacfbe8704d37bfbac3ea3 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > b74c3048fa2e18adc7f0d7cc813a180d4466fa36 > > > Diff: https://reviews.apache.org/r/69054/diff/1/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
