----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69022/ -----------------------------------------------------------
(Updated Oct. 16, 2018, 4:49 p.m.) Review request for hive, Sahil Takiar and Adam Szita. Bugs: HIVE-20737 https://issues.apache.org/jira/browse/HIVE-20737 Repository: hive-git Description ------- 1. Local SparkContext is shared between user sessions and should be closed only when there is no active. 2. Possible race condition in SparkSession.open() in case when user queries run in parallel within the same session. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java 72ff53e3bd ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java bb50129518 ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestLocalHiveSparkClient.java PRE-CREATION Diff: https://reviews.apache.org/r/69022/diff/3/ Changes: https://reviews.apache.org/r/69022/diff/2-3/ Testing ------- Added TestLocalHiveSparkClient test File Attachments ---------------- HIVE-20737.7.patch https://reviews.apache.org/media/uploaded/files/2018/10/15/9cf8a2b3-9ec1-4316-81d0-3cd124b1a9fd__HIVE-20737.7.patch Thanks, denys kuzmenko