----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68474/#review209626 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java Lines 117 (patched) <https://reviews.apache.org/r/68474/#comment294162> nit: if you want to leave the `@return` section empty, then just remove it entirely ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java Lines 127 (patched) <https://reviews.apache.org/r/68474/#comment294163> nit: same as above ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java Lines 178-190 (patched) <https://reviews.apache.org/r/68474/#comment294161> what about changing this to something like `getKey()` and just returning a `String`. I don't think the interface needs to be tied to reading data to a folder on HDFS. ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java Lines 131 (patched) <https://reviews.apache.org/r/68474/#comment294165> why do we run the action just for the l2 cache? - Sahil Takiar On Oct. 10, 2018, 1:20 p.m., Antal Sinkovits wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68474/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 1:20 p.m.) > > > Review request for hive, Naveen Gangam, Sahil Takiar, Adam Szita, and Xuefu > Zhang. > > > Repository: hive-git > > > Description > ------- > > I've modified the SmallTableCache to use guava cache, with soft references. > By using a value loader, I've also eliminated the synchronization on the > intern-ed string of the path. > > > Diffs > ----- > > ql/pom.xml d73deba440702ec39fc5610df28e0fe54baef025 > ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java > da1dd426c9155290e30fd1e3ae7f19a5479a8967 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/AbstractMapJoinTableContainer.java > 9e65fd98d6e4451421641b1429ccf334fe9a9586 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java > 54377428eafdb79e1bbdc8a182eafb46f8febd23 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinBytesTableContainer.java > 0e4b8df036724bd83e85fc3cc70f534272dab4c4 > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainer.java > 74e0b120ea3560a6a2a0074e6c0026b4874b3d5e > > ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/MapJoinTableContainerSerDe.java > 24b8fea33815867ce544fd284437c4d02a21f1a3 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HashTableLoader.java > cf27e92bafdc63096ec0fa8c3106657bab52f370 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SmallTableCache.java > 3293100af96dc60408c53065fa89143ead98f818 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastTableContainer.java > e8dcbf18cb09b190536f920a53d6e9fa870ce33b > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestSmallTableCache.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68474/diff/3/ > > > Testing > ------- > > > Thanks, > > Antal Sinkovits > >
