----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68827/ -----------------------------------------------------------
(Updated Oct. 2, 2018, 5:19 a.m.) Review request for hive and Alexander Kolbasov. Changes ------- I added init() method to MessageFactory, and overriding it in JSONMessageFactory to initialize the static variables. Although the exception traces look mostly similar, I guess this adds a bit more clarity and information about the exception if the regex is invalid. Bugs: HIVE-20545 https://issues.apache.org/jira/browse/HIVE-20545 Repository: hive-git Description ------- Clients can add large-sized parameters in Table/Partition objects. So we need to enable adding regex patterns through HiveConf to match parameters to be filtered from table and partition objects before serialization in HMS notifications. Diffs (updated) ----- standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java 30ea7f81292b0db54f4eb82468191fda38f9a0d4 standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java c681a87a1c6b10a4f9494e49a42282cf90027ad7 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java 7ff168f7931f91fe17f7d38df848ba2eed33c463 standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java 2668b053205f48226da442ce65fcc2d7f6e76763 standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java 30de1c4cfa1cf019186b10583a06da0bf5491634 Diff: https://reviews.apache.org/r/68827/diff/5/ Changes: https://reviews.apache.org/r/68827/diff/4-5/ Testing ------- Thanks, Bharathkrishna Guruvayoor Murali