----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68834/#review209103 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 1808 (patched) <https://reviews.apache.org/r/68834/#comment293363> It would help debugging if the msg included cat.db.table + tblid that was set. standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java Lines 296 (patched) <https://reviews.apache.org/r/68834/#comment293364> I don't see anyone calling this - is thsi needed? standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java Lines 1715 (patched) <https://reviews.apache.org/r/68834/#comment293365> it would make sense to check in the catch that you are getting the expected error msg - Eugene Koifman On Sept. 24, 2018, 8:04 p.m., Jaume Marhuenda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68834/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 8:04 p.m.) > > > Review request for hive, Daniel Dai and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > Expose an API to retrieve the TBL_ID from TBLS in the metastore tables > > > Diffs > ----- > > data/files/exported_table/_metadata 81fbf63a54 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestAuthorizationPreEventListener.java > 05c00094d6 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/TestMetastoreAuthorizationProvider.java > 767321332c > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java f72e08c14f > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java ca4d36f30d > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java > ff411f62d5 > > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java > 78ac909f72 > > standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php > 22deffe1d3 > > standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 38fac465d7 > > standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb > 0192c6da31 > standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift > 85a5c601e0 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ba82a9327c > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > d27224b235 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java > deeb97133d > standalone-metastore/metastore-server/src/main/resources/package.jdo > 2a5f016b1f > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 4937d9d861 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java > df83171648 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > bf302ed491 > > > Diff: https://reviews.apache.org/r/68834/diff/1/ > > > Testing > ------- > > > Thanks, > > Jaume Marhuenda > >
