> On Sept. 17, 2018, 9:15 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Line 507 (original), 666 (patched) > > <https://reviews.apache.org/r/68683/diff/2/?file=2088845#file2088845line669> > > > > please don't make this method more visible; use compile("sel") or > > something...it should work > > denys kuzmenko wrote: > it's impossible to mock and test compile lock behaviour. Entry point is > Driver.compileAndRespond("query"). I do not want to use PowerMock. Actually I > tried and faced many issues with hadoop classes. > > Peter Vary wrote: > What about @VisibleForTesting annotation? It could show the intention at > least...
Added @VisibleForTesting annotation - denys ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68683/#review208625 ----------------------------------------------------------- On Sept. 19, 2018, 9:37 a.m., denys kuzmenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68683/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 9:37 a.m.) > > > Review request for hive, Zoltan Haindrich, Zoltan Haindrich, Naveen Gangam, > and Peter Vary. > > > Bugs: HIVE-20535 > https://issues.apache.org/jira/browse/HIVE-20535 > > > Repository: hive-git > > > Description > ------- > > When removing the compile lock, it is quite risky to remove it entirely. > > It would be good to provide a pool size for the concurrent compilation, so > the administrator can limit the load > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8c39de3e77 > ql/src/java/org/apache/hadoop/hive/ql/CompileLockManager.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 737debd2ad > ql/src/test/org/apache/hadoop/hive/ql/CompileLockTest.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/68683/diff/5/ > > > Testing > ------- > > Added CompileLockTest > > > File Attachments > ---------------- > > HIVE-20535.1.patch > > https://reviews.apache.org/media/uploaded/files/2018/09/13/41f5a84a-70e5-4882-99c1-1cf98c4364e4__HIVE-20535.1.patch > > > Thanks, > > denys kuzmenko > >
