> On Sept. 6, 2018, 1:39 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java > > Lines 278 (patched) > > <https://reviews.apache.org/r/68525/diff/1/?file=2077713#file2077713line282> > > > > Does this class also exist in Calcite? If so, can you please leave a > > note here to remove from Hive once these are made public in Calcite?
no; a but there is something similar inside RexSimplify - but those are private classes I think it would be good to move this to Calcite. - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68525/#review208392 ----------------------------------------------------------- On Aug. 27, 2018, 4:01 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68525/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2018, 4:01 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-20296 > https://issues.apache.org/jira/browse/HIVE-20296 > > > Repository: hive-git > > > Description > ------- > > generalized rule to extract INs from more complex filter conditions as well. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java > eff9a312aaa09a889f0c6a045bd813d1fb633956 > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/rules/TestHivePointLookupOptimizerRule.java > PRE-CREATION > ql/src/test/results/clientpositive/druid/druidmini_test_ts.q.out > a8e6894a9786318ed4362ee37d918a3699f074a0 > ql/src/test/results/clientpositive/llap/bucketpruning1.q.out > 260ba1cbddee7f0946f0cdec1070359ab2a1d2aa > ql/src/test/results/clientpositive/perf/spark/query15.q.out > 67684f6b0bc44c0cae6107be94d131a083eca0e1 > ql/src/test/results/clientpositive/perf/spark/query47.q.out > 690b1054c12f7d588015afc301802d9d2da2d0b9 > ql/src/test/results/clientpositive/perf/spark/query57.q.out > 51e644a87bf4befbe4368cdf03b5eaab6d4f2049 > ql/src/test/results/clientpositive/perf/tez/query15.q.out > e1eca99d95e13070f901b75a406391435b2b4f1d > ql/src/test/results/clientpositive/perf/tez/query47.q.out > d034ea9433a3b1c54c545edf526c215bf79388e1 > ql/src/test/results/clientpositive/perf/tez/query57.q.out > 42cbbdc2a4d8bc469c9d91867faf21fc94a057ea > > > Diff: https://reviews.apache.org/r/68525/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
