----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3008/#review3943 -----------------------------------------------------------
Please update udf_bewteen.q and then attach the updated patch to HIVE-2005. I think this will be ready to commit once this change is made. Thanks! ql/src/test/queries/clientpositive/udf_between.q <https://reviews.apache.org/r/3008/#comment8915> I'm not sure why you changed this testcase. The original version was better. * The first two lines should be: DESCRIBE FUNCTION between DESCRIBE FUNCTION EXTENDED between; * Please call EXPLAIN on each query before running it. * Is there any reason in particular why you create the T1 table instead of reusing the 'src' table that gets created automatically for all CliDriver tests? Loading data will definitely make the test run more slowly. - Carl On 2011-12-16 02:09:08, Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3008/ > ----------------------------------------------------------- > > (Updated 2011-12-16 02:09:08) > > > Review request for hive, John Sichi and Carl Steinbach. > > > Summary > ------- > > Revised version using 'between' UDF > > > This addresses bug HIVE-2005. > https://issues.apache.org/jira/browse/HIVE-2005 > > > Diffs > ----- > > ql/src/test/queries/clientpositive/udf_between.q PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out e63516d > ql/src/test/results/clientpositive/udf_between.q.out PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java e1c47b4 > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g eecd9e7 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBetween.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/3008/diff > > > Testing > ------- > > added new test : udf_between.q > > > Thanks, > > Navis > >
