----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68365/#review207354 -----------------------------------------------------------
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 839 (patched) <https://reviews.apache.org/r/68365/#comment290718> It seems weird that there isn't a constant for "EXTERNAL", but I can't find one. standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java Lines 854 (patched) <https://reviews.apache.org/r/68365/#comment290719> So you test params(EXTERNAL=true),TableType.MANAGED_TABLE params(EXTERNAL=false),TableType.EXTERNAL_TABLE having done all the work you may as well test params(EXTERNAL=false),TableType.MANAGED_TABLE params(EXTERNAL=true),TableType.EXTERNAL_TABLE as well? - Andrew Sherman On Aug. 15, 2018, 8:18 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68365/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 8:18 p.m.) > > > Review request for hive, Andrew Sherman, Peter Vary, and Vihang Karajgaonkar. > > > Bugs: HIVE-19253 > https://issues.apache.org/jira/browse/HIVE-19253 > > > Repository: hive-git > > > Description > ------- > > HIVE-19253: HMS ignores tableType property for external tables > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 8e2f94eb691a72cc4e6410aa76b176032d4af673 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java > b74c3048fa2e18adc7f0d7cc813a180d4466fa36 > > > Diff: https://reviews.apache.org/r/68365/diff/1/ > > > Testing > ------- > > Added unit test to verify the expected behavior. > > > Thanks, > > Alexander Kolbasov > >
