----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68337/#review207250 -----------------------------------------------------------
2 minor comments. You may fix them on commit. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 12565 (patched) <https://reviews.apache.org/r/68337/#comment290580> Will be good to expand on why we are reodering? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 12571 (patched) <https://reviews.apache.org/r/68337/#comment290581> unused. - Ashutosh Chauhan On Aug. 14, 2018, 12:37 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68337/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 12:37 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-20379 > https://issues.apache.org/jira/browse/HIVE-20379 > > > Repository: hive-git > > > Description > ------- > > HIVE-20379 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 361f150193a155d45eb64266f88eb88f0a881ad3 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 2ee562add907c2b57992df27ecbb4fd5e114cdba > ql/src/test/queries/clientpositive/materialized_view_rewrite_part_2.q > 505f7507bc9adb25e544dc422164858fb20fed0e > ql/src/test/results/clientpositive/llap/materialized_view_partitioned.q.out > b12df11a98e55c00c8b77e8292666373f3509364 > > ql/src/test/results/clientpositive/llap/materialized_view_partitioned_3.q.out > 726c660cf21d26cc5cc120d1397243958b49f834 > > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_part_1.q.out > 492bb226fd03d51686e2040aed4766aef7150592 > > ql/src/test/results/clientpositive/llap/materialized_view_rewrite_part_2.q.out > e748ccb010fc755f9d6af82c26c8ccffc26b1a55 > > > Diff: https://reviews.apache.org/r/68337/diff/1/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
