----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67954/#review207091 -----------------------------------------------------------
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java Lines 110 (patched) <https://reviews.apache.org/r/67954/#comment290320> You define these two values both here and in HiveMetaStoreClientPreCatalog. Wouldn't it make more sense to define them once in a shared location (like IMetaStoreClient maybe)? - Alan Gates On Aug. 9, 2018, 10:35 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67954/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 10:35 p.m.) > > > Review request for hive, Alan Gates, Peter Vary, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-20194 > https://issues.apache.org/jira/browse/HIVE-20194 > > > Repository: hive-git > > > Description > ------- > > HIVE-20194: HiveMetastoreClient should use reflection to instantiate embedded > HMS instance > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > a53d4be03d695bf2176436967026757391531bc9 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 91c86a749c7afb06737c850e57f60820710c51f5 > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > 34055d2d4d39dc63d505a5ef95d190aa80a49d14 > > > Diff: https://reviews.apache.org/r/67954/diff/5/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
