-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68108/
-----------------------------------------------------------
(Updated Aug. 3, 2018, 2:56 p.m.)
Review request for hive, Ashutosh Chauhan and Gopal V.
Changes
-------
patch#12
Bugs: HIVE-19097
https://issues.apache.org/jira/browse/HIVE-19097
Repository: hive-git
Description
-------
* open in to or - only column can be on left side
* close ors into in at 2
* small fix to or closer; to be able to spot nested cases
* make IN stat estimation better ; it could have (highly) overestimated the
selectivity in multi column cases.
* pending qtests for the latest IN stat estimation changes...
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 093b4a73f3
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
97e405970f
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java
01ad41c497
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java
f544f58632
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
01179c805f
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
fa941a1b25
ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java
b57b5ddc2c
ql/src/test/queries/clientpositive/pointlookup.q 1b65cec71c
ql/src/test/queries/clientpositive/pointlookup2.q fe19381368
ql/src/test/queries/clientpositive/pointlookup3.q f98feeb164
ql/src/test/results/clientpositive/alter_partition_coltype.q.out 5d033a3c01
ql/src/test/results/clientpositive/annotate_stats_filter.q.out 54395886d2
ql/src/test/results/clientpositive/annotate_stats_part.q.out bafc6de51e
ql/src/test/results/clientpositive/auto_join19.q.out 3e07ec06de
ql/src/test/results/clientpositive/cbo_rp_simple_select.q.out 2e7d79660b
ql/src/test/results/clientpositive/cbo_simple_select.q.out 33f0e71080
ql/src/test/results/clientpositive/druid_intervals.q.out a5203c3182
ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out
97922c2636
ql/src/test/results/clientpositive/filter_cond_pushdown.q.out b84a2d4b79
ql/src/test/results/clientpositive/filter_in_or_dup.q.out b50027d01a
ql/src/test/results/clientpositive/fold_eq_with_case_when.q.out d06fb60345
ql/src/test/results/clientpositive/groupby_multi_single_reducer3.q.out
7ec51ffd07
ql/src/test/results/clientpositive/implicit_cast_during_insert.q.out
5e974bf7bb
ql/src/test/results/clientpositive/join45.q.out 4365d521b2
ql/src/test/results/clientpositive/join47.q.out c04b94b911
ql/src/test/results/clientpositive/list_bucket_query_multiskew_2.q.out
98ad3656e7
ql/src/test/results/clientpositive/llap/bucketpruning1.q.out cc637db05b
ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out
1330a86426
ql/src/test/results/clientpositive/llap/cbo_simple_select.q.out a35edb42a8
ql/src/test/results/clientpositive/llap/check_constraint.q.out 123a3e46fc
ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out
8f06ee58ce
ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
e03cd3437e
ql/src/test/results/clientpositive/llap/explainuser_1.q.out 4db83c149d
ql/src/test/results/clientpositive/llap/explainuser_2.q.out 47941fa1ae
ql/src/test/results/clientpositive/llap/kryo.q.out 234bae89c7
ql/src/test/results/clientpositive/llap/llap_decimal64_reader.q.out
88ddd9c076
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb.q.out
1841f1f4d3
ql/src/test/results/clientpositive/llap/materialized_view_rewrite_ssb_2.q.out
d7c92d8c59
ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 65eec521a2
ql/src/test/results/clientpositive/llap/vector_between_in.q.out 801dda315a
ql/src/test/results/clientpositive/llap/vector_string_decimal.q.out
54d9914caa
ql/src/test/results/clientpositive/llap/vector_struct_in.q.out 3756a2f4ab
ql/src/test/results/clientpositive/llap/vector_windowing_multipartitioning.q.out
725ed34acb
ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out
74ac56d1c6
ql/src/test/results/clientpositive/llap/vectorized_case.q.out d444ae86a1
ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out
ba004e9716
ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out 54d5be0b02
ql/src/test/results/clientpositive/mapjoin47.q.out cf29fa06b9
ql/src/test/results/clientpositive/parquet_vectorization_0.q.out 01f89513c3
ql/src/test/results/clientpositive/pcr.q.out 919b71234d
ql/src/test/results/clientpositive/pcs.q.out c8819cc0dc
ql/src/test/results/clientpositive/perf/spark/query10.q.out 45dfc5391c
ql/src/test/results/clientpositive/perf/spark/query12.q.out ad7e91215e
ql/src/test/results/clientpositive/perf/spark/query13.q.out fb2a061c63
ql/src/test/results/clientpositive/perf/spark/query15.q.out 3d6fbdac77
ql/src/test/results/clientpositive/perf/spark/query16.q.out 2f51a71ef1
ql/src/test/results/clientpositive/perf/spark/query17.q.out 23f1e85927
ql/src/test/results/clientpositive/perf/spark/query18.q.out f8bec59c53
ql/src/test/results/clientpositive/perf/spark/query20.q.out 76fae0be21
ql/src/test/results/clientpositive/perf/spark/query23.q.out 08b0f937f1
ql/src/test/results/clientpositive/perf/spark/query27.q.out e7ed297f32
ql/src/test/results/clientpositive/perf/spark/query29.q.out b070fc038f
ql/src/test/results/clientpositive/perf/spark/query34.q.out b40081e4f0
ql/src/test/results/clientpositive/perf/spark/query36.q.out d3bea7698c
ql/src/test/results/clientpositive/perf/spark/query37.q.out 17c85a6ad4
ql/src/test/results/clientpositive/perf/spark/query45.q.out d61f8b8052
ql/src/test/results/clientpositive/perf/spark/query46.q.out ccce45c4d2
ql/src/test/results/clientpositive/perf/spark/query48.q.out 60a4767a14
ql/src/test/results/clientpositive/perf/spark/query53.q.out 2b1cdfea98
ql/src/test/results/clientpositive/perf/spark/query56.q.out 47059878a4
ql/src/test/results/clientpositive/perf/spark/query63.q.out b506455dbf
ql/src/test/results/clientpositive/perf/spark/query68.q.out faf5d991bb
ql/src/test/results/clientpositive/perf/spark/query69.q.out 83b55df61b
ql/src/test/results/clientpositive/perf/spark/query71.q.out bf9c06debf
ql/src/test/results/clientpositive/perf/spark/query73.q.out 20ec874e88
ql/src/test/results/clientpositive/perf/spark/query74.q.out 3678906bc0
ql/src/test/results/clientpositive/perf/spark/query79.q.out 9355239c52
ql/src/test/results/clientpositive/perf/spark/query82.q.out bc627f1ce3
ql/src/test/results/clientpositive/perf/spark/query83.q.out 6fad2cafff
ql/src/test/results/clientpositive/perf/spark/query85.q.out 572ba54f78
ql/src/test/results/clientpositive/perf/spark/query89.q.out 1acc577669
ql/src/test/results/clientpositive/perf/spark/query91.q.out de8977da51
ql/src/test/results/clientpositive/perf/spark/query98.q.out c82607d9a1
ql/src/test/results/clientpositive/perf/tez/query10.q.out a8f097fb59
ql/src/test/results/clientpositive/perf/tez/query12.q.out d3d8df00cd
ql/src/test/results/clientpositive/perf/tez/query13.q.out 5cd4e27de3
ql/src/test/results/clientpositive/perf/tez/query15.q.out 3c7ae664b1
ql/src/test/results/clientpositive/perf/tez/query16.q.out 5652f3b019
ql/src/test/results/clientpositive/perf/tez/query17.q.out e185775904
ql/src/test/results/clientpositive/perf/tez/query18.q.out 1b9b2fba02
ql/src/test/results/clientpositive/perf/tez/query20.q.out 7d126a8de9
ql/src/test/results/clientpositive/perf/tez/query23.q.out aab3f9360c
ql/src/test/results/clientpositive/perf/tez/query27.q.out 7ea13c8f9c
ql/src/test/results/clientpositive/perf/tez/query29.q.out 9bfcdfa9c1
ql/src/test/results/clientpositive/perf/tez/query34.q.out 9b7b482d3b
ql/src/test/results/clientpositive/perf/tez/query36.q.out c86c9e42aa
ql/src/test/results/clientpositive/perf/tez/query37.q.out 2b3ae52aee
ql/src/test/results/clientpositive/perf/tez/query45.q.out edb047d3f5
ql/src/test/results/clientpositive/perf/tez/query46.q.out 708a852051
ql/src/test/results/clientpositive/perf/tez/query48.q.out 1cf8d5c0da
ql/src/test/results/clientpositive/perf/tez/query53.q.out 3567534ac4
ql/src/test/results/clientpositive/perf/tez/query56.q.out 0d8ac48fe4
ql/src/test/results/clientpositive/perf/tez/query63.q.out a5b7b5a788
ql/src/test/results/clientpositive/perf/tez/query64.q.out 6d3edd3173
ql/src/test/results/clientpositive/perf/tez/query68.q.out 24b250282f
ql/src/test/results/clientpositive/perf/tez/query69.q.out 738508a1a9
ql/src/test/results/clientpositive/perf/tez/query71.q.out 4521aabc9f
ql/src/test/results/clientpositive/perf/tez/query73.q.out cfa5213b5e
ql/src/test/results/clientpositive/perf/tez/query74.q.out 854e6dc3aa
ql/src/test/results/clientpositive/perf/tez/query79.q.out 105a7396a4
ql/src/test/results/clientpositive/perf/tez/query82.q.out bb5a9e9a0b
ql/src/test/results/clientpositive/perf/tez/query83.q.out f766e8dd9b
ql/src/test/results/clientpositive/perf/tez/query85.q.out 4e42d69735
ql/src/test/results/clientpositive/perf/tez/query89.q.out ee3374ea5c
ql/src/test/results/clientpositive/perf/tez/query91.q.out a53c7d796d
ql/src/test/results/clientpositive/perf/tez/query98.q.out 4915d2b236
ql/src/test/results/clientpositive/pointlookup.q.out 69ae098a41
ql/src/test/results/clientpositive/pointlookup2.q.out 1eba541ff0
ql/src/test/results/clientpositive/pointlookup3.q.out 8835d4188c
ql/src/test/results/clientpositive/ppd_transform.q.out b38088f16a
ql/src/test/results/clientpositive/remove_exprs_stats.q.out a9c0051371
ql/src/test/results/clientpositive/smb_mapjoin_47.q.out 894ab3d3af
ql/src/test/results/clientpositive/spark/auto_join19.q.out d7d8caee33
ql/src/test/results/clientpositive/spark/bucketsortoptimize_insert_7.q.out
e07904ac44
ql/src/test/results/clientpositive/spark/cbo_simple_select.q.out a35edb42a8
ql/src/test/results/clientpositive/spark/groupby_multi_single_reducer3.q.out
7eff987d20
ql/src/test/results/clientpositive/spark/parquet_vectorization_0.q.out
30b5a2e8c9
ql/src/test/results/clientpositive/spark/pcr.q.out 83437e5593
ql/src/test/results/clientpositive/spark/ppd_transform.q.out 4dfc0fed6e
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out
24202522f5
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_2.q.out
4606a0a6f0
ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 736321b369
ql/src/test/results/clientpositive/spark/vector_between_in.q.out 8b1a2be89b
ql/src/test/results/clientpositive/spark/vectorization_0.q.out c6b204f3df
ql/src/test/results/clientpositive/spark/vectorized_case.q.out 0bf2a4bfa5
ql/src/test/results/clientpositive/stat_estimate_drill.q.out 8a008c8fbf
ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 5a50431d26
ql/src/test/results/clientpositive/vector_date_1.q.out cb952ecf27
ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out
966edad025
ql/src/test/results/clientpositive/vector_struct_in.q.out d073ec6bce
ql/src/test/results/clientpositive/vectorized_case.q.out 828131f8c6
ql/src/test/results/clientpositive/vectorized_timestamp.q.out be1891999c
Diff: https://reviews.apache.org/r/68108/diff/5/
Changes: https://reviews.apache.org/r/68108/diff/4-5/
Testing
-------
Thanks,
Zoltan Haindrich
