----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68124/#review206717 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java Lines 451 (patched) <https://reviews.apache.org/r/68124/#comment289803> We can remove this first block, it does not buy us much in terms of algorithm perfomance, and method would have no restriction on start operator (plus more readable). ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java Lines 462 (patched) <https://reviews.apache.org/r/68124/#comment289804> Probably more useful to do the inverse, the private method void and the public method returns the operators in the work? - Jesús Camacho Rodríguez On Aug. 1, 2018, 12:27 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68124/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 12:27 a.m.) > > > Review request for hive, Jesús Camacho Rodríguez and Jason Dere. > > > Bugs: HIVE-20252 > https://issues.apache.org/jira/browse/HIVE-20252 > > > Repository: hive-git > > > Description > ------- > > See Jira. > > removeSemiJoinCyclesDueToMapsideJoins is deprecated, although it has changes. > I will eventually remove it and can be ignored. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 7b2ae40107 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 538aa5e924 > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java c3eb886fd2 > > > Diff: https://reviews.apache.org/r/68124/diff/3/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
