BELUGA BEHR created HIVE-20257:
----------------------------------
Summary: Improvements to Hive.java
Key: HIVE-20257
URL: https://issues.apache.org/jira/browse/HIVE-20257
Project: Hive
Issue Type: Improvement
Affects Versions: 3.0.0, 4.0.0
Reporter: BELUGA BEHR
Fix For: 4.0.0
Various fixes to {{Hive.java}}
* Use Log4J parameters in logging statements
* Fix check styles
* Make code more concise
* Remove "log and throw" code
* Replaced calls to deprecated code
* Removed superfluous calls to {{toString}}
"log and throw" is considered and anti-pattern. Only the highest level catch
should be providing detailed logging otherwise we print the same stack trace to
the logs several times and with different context (for example when an
exception is wrapped, we get two different logging events).
https://community.oracle.com/docs/DOC-983543#logAndThrow
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)