----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67969/#review206245 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java Line 87 (original), 88 (patched) <https://reviews.apache.org/r/67969/#comment289150> This is not introduced in this patch, but maybe this "if" should be a method since the same condition is checked in 3 places - to keep it in sync. ql/src/test/queries/clientpositive/acid_no_buckets.q Lines 37 (patched) <https://reviews.apache.org/r/67969/#comment289149> I don't understand this comment. There was update/insert done (line 25) since last analyze at line 22-23. Shouldn't analyze at 34-35 change stats? Or are they auto updated after each statement? - Eugene Koifman On July 18, 2018, 4:19 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67969/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 4:19 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 64f9c70f05 > ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java > 03cceace40 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 49709e596e > > ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java > 28d4de7f7b > ql/src/test/queries/clientpositive/acid_no_buckets.q bcf9e0634b > ql/src/test/results/clientpositive/llap/acid_no_buckets.q.out 36a6a5d5d1 > > > Diff: https://reviews.apache.org/r/67969/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
