----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67966/#review206217 -----------------------------------------------------------
common/src/java/org/apache/hive/http/ProfileServlet.java Lines 172 (patched) <https://reviews.apache.org/r/67966/#comment289107> Input validation (most of these are typed, as far as I know) common/src/java/org/apache/hive/http/ProfileServlet.java Lines 184 (patched) <https://reviews.apache.org/r/67966/#comment289106> Change to a tryLock + timeout - fail with an error if the GET request can't get a lock after a while. - Gopal V On July 18, 2018, 6:42 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67966/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 6:42 p.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-20202 > https://issues.apache.org/jira/browse/HIVE-20202 > > > Repository: hive-git > > > Description > ------- > > HIVE-20202: Add profiler endpoint to httpserver > > > Diffs > ----- > > bin/hive 1ade51e > common/src/java/org/apache/hive/common/util/ProcessUtils.java PRE-CREATION > common/src/java/org/apache/hive/http/HttpServer.java 3cb7a33 > common/src/java/org/apache/hive/http/ProfileServlet.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/67966/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
