----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67815/#review205681 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java Line 215 (original), 218 (patched) <https://reviews.apache.org/r/67815/#comment288580> Can this be deleted? Same with `GetStageInfoJob` ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java Lines 228 (patched) <https://reviews.apache.org/r/67815/#comment288582> Looks very similar to `getSparkJobInfo` should be re-factored ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java Lines 256 (patched) <https://reviews.apache.org/r/67815/#comment288581> This looks very similar to `GetJobInfoJob`, can the two be re-factored to share common code? - Sahil Takiar On July 3, 2018, 6:32 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67815/ > ----------------------------------------------------------- > > (Updated July 3, 2018, 6:32 p.m.) > > > Review request for hive, Peter Vary and Sahil Takiar. > > > Repository: hive-git > > > Description > ------- > > Adding GetSparkStagesInfoJob which gets the jobInfo and stageInfos in a > single job > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/impl/RemoteSparkJobStatus.java > 832832b325d7eb0e43fb34a4306d7ffa43ceaa78 > > > Diff: https://reviews.apache.org/r/67815/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
