> On June 19, 2018, 8:53 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RenderStrategy.java > > Lines 43 (patched) > > <https://reviews.apache.org/r/67636/diff/1/?file=2042205#file2042205line43> > > > > how much of this code is new coded vs. copied from other classes?
The methods getReport, isSameAsPreviousProgress, printStatus are copied from existing. - Bharathkrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67636/#review205020 ----------------------------------------------------------- On June 18, 2018, 8:41 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67636/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 8:41 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > This logic is similar to the RenderStrategy used in Tez to print the progress > bar. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 933bda4ad01a6f7878019a7b4c971a0c39068ae2 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java > ad8d1a7f1cca3a763bb7c07335998ab7d39d7598 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/LocalSparkJobMonitor.java > 2a6c33bfd4824c96e7004cd1ecce48c62c97d685 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java > 004b50ba95934280cf302055a46a5d984b421e07 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RenderStrategy.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 3531ac25a9959aacd5766a9a42316890c68a1cd5 > > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/status/TestSparkJobMonitor.java > e66354f0869738bd3cf0eb831c13fa6af1eda256 > service/src/java/org/apache/hive/service/ServiceUtils.java > 226e43244df10c22143b91f92ef312e56739d036 > > service/src/java/org/apache/hive/service/cli/SparkProgressMonitorStatusMapper.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 68fe8d8aa143fafbfc611253ce3a12065016a537 > > > Diff: https://reviews.apache.org/r/67636/diff/1/ > > > Testing > ------- > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
