----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67420/#review204331 -----------------------------------------------------------
streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java Lines 144 (patched) <https://reviews.apache.org/r/67420/#comment286771> newInstance() might mean that you can avoid using the conf for the cache setting and instance directly skip the cache. streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java Lines 214 (patched) <https://reviews.apache.org/r/67420/#comment286770> This might not be necessary to do here. - Gopal V On June 5, 2018, 6:39 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67420/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 6:39 a.m.) > > > Review request for hive, Eugene Koifman and Gopal V. > > > Bugs: HIVE-19772 > https://issues.apache.org/jira/browse/HIVE-19772 > > > Repository: hive-git > > > Description > ------- > > HIVE-19772: Streaming ingest V2 API can generate invalid orc file if > interrupted > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java e187ce1 > streaming/src/java/org/apache/hive/streaming/AbstractRecordWriter.java > 0866850 > streaming/src/java/org/apache/hive/streaming/HiveStreamingConnection.java > f697211 > > > Diff: https://reviews.apache.org/r/67420/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
