Changes for Build #1144
[jvs] HIVE-1040 [jira] use sed rather than diff for masking out noise in
diff-based
tests
(Marek Sapota via John Sichi)
Summary:
Replace diff -I with regex masking in Java
The current diff -I approach has two problems: (1) it does not allow resolution
finer than line-level, so it's impossible to mask out pattern occurrences within
a line, and (2) it produces unmasked files, so if you run diff on the command
line to compare the result .q.out with the checked-in file, you see the noise.
My suggestion is to first run sed to replace noise patterns with an
unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files
without using any -I.
This would require a one-time hit to update all existing .q.out files so that
they would contain the pre-masked results.
Test Plan: EMPTY
Reviewers: JIRA, jsichi
Reviewed By: jsichi
CC: jsichi
Differential Revision: 597
1 tests failed.
REGRESSION: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_inputddl5
Error Message:
Unexpected exception See build/ql/tmp/hive.log, or try "ant test ...
-Dtest.silent=false" to get more logs.
Stack Trace:
junit.framework.AssertionFailedError: Unexpected exception
See build/ql/tmp/hive.log, or try "ant test ... -Dtest.silent=false" to get
more logs.
at junit.framework.Assert.fail(Assert.java:50)
at
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_inputddl5(TestCliDriver.java:16627)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:243)
at junit.framework.TestSuite.run(TestSuite.java:238)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:422)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:931)
at
org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:785)
The Apache Jenkins build system has built Hive-trunk-h0.21 (build #1144)
Status: Failure
Check console output at https://builds.apache.org/job/Hive-trunk-h0.21/1144/ to
view the results.
