-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67351/
-----------------------------------------------------------
(Updated June 5, 2018, 7:54 a.m.)
Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar.
Changes
-------
Addressed Vihang's comment, and fixed test failures:
- Added transaction to the original getMPartition method
- Added javadoc
- Removed accidentally added extra line from HiveMetaStore.java
Bugs: HIVE-19718
https://issues.apache.org/jira/browse/HIVE-19718
Repository: hive-git
Description
-------
Various optimization for addPartitions call:
- Push down table object to convertToMPart
- Push down partitionKeys to startAddPartition -> doesPartitionExist ->
getMPartition, so it does not have to query the table object for every time if
we add multiple partitions for the same table
- The original getMPartition used to query the table every time. Created a new
version of getMPartition, which can use the provided partitionKeys instead of
querying it again.
Diffs (updated)
-----
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
0cc0ae5
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
d8b8414
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
b15d89d
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
283798c
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
9da8d72
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
0461c4e
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
b71eda4
Diff: https://reviews.apache.org/r/67351/diff/2/
Changes: https://reviews.apache.org/r/67351/diff/1-2/
Testing
-------
Run several performance tests with Sasha's performance tool. These
optimisations shave of ~10% of the runtime
Thanks,
Peter Vary
