> On May 25, 2018, 10:58 p.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > > Lines 4402 (patched) > > <https://reviews.apache.org/r/67329/diff/2/?file=2030323#file2030323line4402> > > > > actually this is unused variable.. i left a note to fix some test case. > > will fixup this parent and child data type variation mismatch in next patch.
(d + 1) % (d / 2) where d is DECIMAL_64 exhibits this behaviour. Mod and Divide does not support DECIMAL_64 whereas Addition does. So this expression becomes (+: DECIMAL_64) (%: NONE) (/: NONE). Mod is parent whose output variation is NONE but one of its child (+) has DECIMAL_64 variation which should be casted up to avoid runtime ClassCastException. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67329/#review203920 ----------------------------------------------------------- On May 25, 2018, 8:25 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67329/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 8:25 p.m.) > > > Review request for hive and Matt McCline. > > > Bugs: HIVE-19629 > https://issues.apache.org/jira/browse/HIVE-19629 > > > Repository: hive-git > > > Description > ------- > > HIVE-19629: Enable Decimal64 reader after orc version upgrade > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 931533a > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestAcidOnTez.java > 0af91bd > itests/src/test/resources/testconfiguration.properties d146f92 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > 6d29163 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java > 7af1b05 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > feccb87 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 4033b37 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 1cfe929 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java > de19b1d > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/ConsumerFileMetadata.java > bf139c0 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java > 0012afb > pom.xml e48974b > ql/pom.xml 06124f7 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 2246901 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedInputFormatInterface.java > e74b185 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java > 6588385 > ql/src/java/org/apache/hadoop/hive/ql/io/NullRowsInputFormat.java e632d43 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f461364 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRawRecordMerger.java > 8c7c72e > ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java 7485e60 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java 1a6db1f > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 5b001a0 > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java > d2e1a68 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java > c581bba > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 71682af > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java > 646b214 > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetInputFormat.java > ed6d577 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 394f826 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java af43b14 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > fb2335a > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java ef678a8 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java > d8a7af8 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSerDeStats.java 1533ffa > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedORCReader.java > 0c9c95d > > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java > e478371 > ql/src/test/queries/clientpositive/llap_acid2.q a409c26 > ql/src/test/queries/clientpositive/llap_decimal64_reader.q PRE-CREATION > ql/src/test/queries/clientpositive/llap_uncompressed.q 875356c > ql/src/test/results/clientpositive/acid_mapjoin.q.out 76a781e > ql/src/test/results/clientpositive/acid_nullscan.q.out 6dad497 > ql/src/test/results/clientpositive/acid_table_stats.q.out 2596922 > ql/src/test/results/clientpositive/annotate_stats_part.q.out 9e45101 > ql/src/test/results/clientpositive/annotate_stats_table.q.out b502957 > ql/src/test/results/clientpositive/autoColumnStats_4.q.out 5be906e > > ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out > a717b80 > > ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_2.q.out > fa58add > ql/src/test/results/clientpositive/deleteAnalyze.q.out d98114b > ql/src/test/results/clientpositive/druid/druidmini_mv.q.out 35f4c1b > ql/src/test/results/clientpositive/extrapolate_part_stats_date.q.out > f1cd05c > ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out > bec6dd4 > ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out > 1a13b21 > ql/src/test/results/clientpositive/llap/acid_bucket_pruning.q.out c89c22c > ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out > 38a9770 > ql/src/test/results/clientpositive/llap/alter_merge_orc.q.out 7b33e8e > ql/src/test/results/clientpositive/llap/alter_merge_stats_orc.q.out c8b831d > ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out > 11a9c0e > ql/src/test/results/clientpositive/llap/default_constraint.q.out cb69af7 > ql/src/test/results/clientpositive/llap/deleteAnalyze.q.out a125fd6 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > 22f2860 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out > 048712e > > ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out > 709100f > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out > 72f3b8b > > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out > fa51dd3 > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out > 5a9d263 > > ql/src/test/results/clientpositive/llap/extrapolate_part_stats_partial_ndv.q.out > 8a0da7d > > ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out > b0089ef > ql/src/test/results/clientpositive/llap/llap_acid2.q.out 4d74a17 > ql/src/test/results/clientpositive/llap/llap_decimal64_reader.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/llap_nullscan.q.out 2393450 > ql/src/test/results/clientpositive/llap/llap_partitioned.q.out d827add > ql/src/test/results/clientpositive/llap/llap_text.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/llap_uncompressed.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/materialized_view_create.q.out > bcd4144 > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite.q.out > 60e7f32 > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_3.q.out > cca7d9f > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_4.q.out > 7aef9be > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_5.q.out > 2f0bf3d > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_dummy.q.out > 9116089 > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_multi_db.q.out > 4cf7bce > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_rebuild_dummy.q.out > 338a848 > > ql/src/test/results/clientpositive/llap/materialized_view_create_rewrite_time_window.q.out > 164568c > ql/src/test/results/clientpositive/llap/materialized_view_describe.q.out > 272cbec > ql/src/test/results/clientpositive/llap/materialized_view_drop.q.out > ceb34f7 > ql/src/test/results/clientpositive/llap/mergejoin.q.out 832ed48 > ql/src/test/results/clientpositive/llap/orc_analyze.q.out abbbbf9 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 435e3fc > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out c078326 > ql/src/test/results/clientpositive/llap/orc_merge1.q.out f5d94f9 > ql/src/test/results/clientpositive/llap/orc_merge10.q.out 32a4306 > ql/src/test/results/clientpositive/llap/orc_merge11.q.out a4ec749 > ql/src/test/results/clientpositive/llap/orc_merge2.q.out eade7a7 > ql/src/test/results/clientpositive/llap/orc_merge3.q.out d82b77c > ql/src/test/results/clientpositive/llap/orc_merge4.q.out 16818b4 > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 52a3c73 > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > 450b43c > ql/src/test/results/clientpositive/llap/results_cache_invalidation.q.out > ad30ece > ql/src/test/results/clientpositive/llap/schema_evol_stats.q.out eccb983 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_complex_llap_io.q.out > 5052fe6 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive_llap_io.q.out > df136bf > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_llap_io.q.out > 7259b33 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table_llap_io.q.out > 8f83622 > ql/src/test/results/clientpositive/llap/vector_char_varchar_1.q.out 1a32227 > ql/src/test/results/clientpositive/llap/vector_create_struct_table.q.out > c08154e > ql/src/test/results/clientpositive/llap/vector_decimal_10_0.q.out 5e835cd > ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out > 902d137 > ql/src/test/results/clientpositive/llap/vector_decimal_cast.q.out 67630b4 > ql/src/test/results/clientpositive/llap/vector_decimal_precision.q.out > 50e4305 > ql/src/test/results/clientpositive/llap/vector_decimal_round.q.out 6737052 > ql/src/test/results/clientpositive/llap/vector_decimal_udf2.q.out 9e1c8d7 > ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 2ea9018 > ql/src/test/results/clientpositive/llap/vector_groupby_mapjoin.q.out > 98e6e54 > ql/src/test/results/clientpositive/llap/vector_groupby_sort_11.q.out > b772e9a > ql/src/test/results/clientpositive/llap/vector_groupby_sort_8.q.out 74ad6ae > ql/src/test/results/clientpositive/llap/vector_llap_text_1.q.out f7721b6 > ql/src/test/results/clientpositive/llap/vector_map_order.q.out 02fc5a0 > ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out 09a53d0 > ql/src/test/results/clientpositive/llap/vector_null_map.q.out 666f7fd > > ql/src/test/results/clientpositive/llap/vector_orc_merge_incompat_schema.q.out > f1a4ea3 > ql/src/test/results/clientpositive/llap/vector_order_null.q.out 08c57bd > > ql/src/test/results/clientpositive/llap/vector_outer_reference_windowed.q.out > 89c14d5 > ql/src/test/results/clientpositive/llap/vector_ptf_1.q.out 568549d > > ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out > 1ed694d > ql/src/test/results/clientpositive/llap/vector_retry_failure.q.out 64e158e > ql/src/test/results/clientpositive/llap/vector_windowing.q.out 428ee8d > ql/src/test/results/clientpositive/llap/vector_windowing_expressions.q.out > 148f82b > ql/src/test/results/clientpositive/llap/vector_windowing_gby.q.out d87e96f > ql/src/test/results/clientpositive/llap/vector_windowing_gby2.q.out 8dcb900 > > ql/src/test/results/clientpositive/llap/vector_windowing_multipartitioning.q.out > 01bcb69 > ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out > 5466297 > ql/src/test/results/clientpositive/llap/vector_windowing_order_null.q.out > f950c4c > > ql/src/test/results/clientpositive/llap/vector_windowing_range_multiorder.q.out > 3a1b9c5e > ql/src/test/results/clientpositive/llap/vector_windowing_rank.q.out 2bf3b07 > ql/src/test/results/clientpositive/llap/vector_windowing_streaming.q.out > e120391 > ql/src/test/results/clientpositive/llap/vector_windowing_windowspec.q.out > e3d52d2 > ql/src/test/results/clientpositive/llap/vector_windowing_windowspec4.q.out > 3cebb04 > ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out > 7325ac0 > ql/src/test/results/clientpositive/llap/vectorized_bucketmapjoin1.q.out > 61c5051 > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out > d3ab509 > ql/src/test/results/clientpositive/orc_file_dump.q.out 2067145 > ql/src/test/results/clientpositive/orc_merge10.q.out 0b8e2dd > ql/src/test/results/clientpositive/orc_merge11.q.out a4ec749 > ql/src/test/results/clientpositive/orc_merge12.q.out a999b8a > ql/src/test/results/clientpositive/row__id.q.out 18af000 > ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out 7b33e8e > ql/src/test/results/clientpositive/spark/alter_merge_stats_orc.q.out > 9337387 > ql/src/test/results/clientpositive/spark/orc_merge1.q.out 63b81d7 > ql/src/test/results/clientpositive/spark/orc_merge2.q.out 39b0216 > ql/src/test/results/clientpositive/spark/orc_merge3.q.out 10e9a17 > ql/src/test/results/clientpositive/spark/orc_merge4.q.out a66bda7 > ql/src/test/results/clientpositive/spark/orc_merge5.q.out 795df68 > ql/src/test/results/clientpositive/spark/orc_merge6.q.out 7a53efd > ql/src/test/results/clientpositive/spark/orc_merge7.q.out e2151ef > ql/src/test/results/clientpositive/spark/orc_merge8.q.out d37de44 > ql/src/test/results/clientpositive/spark/orc_merge9.q.out 31bcd90 > ql/src/test/results/clientpositive/spark/orc_merge_incompat1.q.out 0dfaec8 > ql/src/test/results/clientpositive/spark/orc_merge_incompat2.q.out b0db735 > ql/src/test/results/clientpositive/spark/vector_data_types.q.out 9f7fadc > ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out > 0336982 > ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out > fe5fd23 > > ql/src/test/results/clientpositive/tez/acid_vectorization_original_tez.q.out > a6f12af > ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out ce8ab92 > ql/src/test/results/clientpositive/tez/orc_merge12.q.out 673bad2 > ql/src/test/results/clientpositive/typechangetest.q.out bbb53a0 > ql/src/test/results/clientpositive/vector_case_when_1.q.out b2ac291 > ql/src/test/results/clientpositive/vector_case_when_2.q.out 159c983 > ql/src/test/results/clientpositive/vector_char_2.q.out ae9910d > ql/src/test/results/clientpositive/vector_coalesce_2.q.out 48d38c3 > ql/src/test/results/clientpositive/vector_data_types.q.out c2a2fce > ql/src/test/results/clientpositive/vector_interval_1.q.out 8c0086e > ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out 01e915b > standalone-metastore/pom.xml 467e17a > streaming/src/test/org/apache/hive/streaming/TestStreaming.java 042fdbe > > > Diff: https://reviews.apache.org/r/67329/diff/2/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
