> On May 11, 2018, 3:22 p.m., Sahil Takiar wrote: > > common/src/java/org/apache/hive/common/util/DateUtils.java > > Lines 39 (patched) > > <https://reviews.apache.org/r/67073/diff/1/?file=2019551#file2019551line39> > > > > why does this need to be `ThreadLocal`? there doesn't seem to be > > anything thread specific to this object > > Bharathkrishna Guruvayoor Murali wrote: > The class DateUtils is mentioned to be thread-safe class (in javadoc > comment). and the existing date format is created as a threadlocal. > So I thought this one too should be a threadlocal to keep it thread-safe.
make sense - Sahil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202942 ----------------------------------------------------------- On May 10, 2018, 9:55 p.m., Bharathkrishna Guruvayoor Murali wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67073/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 9:55 p.m.) > > > Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > Adding support to retain the time part (HH:mm:ss) for add_months UDF when the > input is given as timestamp format. > > > Diffs > ----- > > common/src/java/org/apache/hive/common/util/DateUtils.java > 65f3b9401916abdfa52fbf75d115ba6b61758fb0 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > dae4b97b4a17e98122431e5fda655fd9f873fdb5 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java > af9b6c43c7dafc69c4944eab02894786af306f35 > > > Diff: https://reviews.apache.org/r/67073/diff/1/ > > > Testing > ------- > > Added unit tests. > > > Thanks, > > Bharathkrishna Guruvayoor Murali > >
