> On April 24, 2018, 11:55 a.m., Peter Vary wrote: > > Thanks Marta for the patch! These messages will be usefull. > > Two small things / questions below. > > > > Peter
Thanks a lot Peter for the review! > On April 24, 2018, 11:55 a.m., Peter Vary wrote: > > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java > > Lines 66 (patched) > > <https://reviews.apache.org/r/66774/diff/1/?file=2010982#file2010982line66> > > > > Does this result a duplication in the log for the exception messages? You are right, the exception gets logged anyway, so these lines are not necessary. I removed them. > On April 24, 2018, 11:55 a.m., Peter Vary wrote: > > service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java > > Lines 113 (patched) > > <https://reviews.apache.org/r/66774/diff/1/?file=2010986#file2010986line116> > > > > nit: formatting? Something went wrong here. Fixed and few other formatting issues. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66774/#review201826 ----------------------------------------------------------- On April 24, 2018, 10:34 a.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66774/ > ----------------------------------------------------------- > > (Updated April 24, 2018, 10:34 a.m.) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-19285 > https://issues.apache.org/jira/browse/HIVE-19285 > > > Repository: hive-git > > > Description > ------- > > Subclasses of MetaDataOperation are not writing anything to the logs. It > would be useful to have some INFO and DEBUG level logging in these classes. > > > Diffs > ----- > > > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java > 7944467 > > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java > d67ea90 > > service/src/java/org/apache/hive/service/cli/operation/GetCrossReferenceOperation.java > 99ccd4e > > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java > 091bf50 > > service/src/java/org/apache/hive/service/cli/operation/GetPrimaryKeysOperation.java > e603fdd > > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java > de09ec9 > > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java > 59cfbb2 > > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java > c9233d0 > > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java > ac078b4 > > service/src/java/org/apache/hive/service/cli/operation/MetadataOperation.java > bf7c021 > > > Diff: https://reviews.apache.org/r/66774/diff/1/ > > > Testing > ------- > > Just adding some additional log messages. Tested locally by checking the log > messages for different use cases > > > Thanks, > > Marta Kuczora > >
