> On April 19, 2018, 10:48 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/Driver.java
> > Lines 1324 (patched)
> > <https://reviews.apache.org/r/66485/diff/5/?file=2005161#file2005161line1324>
> >
> > why not use TxnUtils.createValidCompactWriteIdList() and
> > ValidCompactorWriteIdList. It sets HWM to minOpen-1 - that is what it's for
that seems to require different types that this code doesn't have... as far as
I see it would need to call metastore or rebuild another object from scratch.
There are too many (Table|Valid|WriteIds|*){3,} classes :)
> On April 19, 2018, 10:48 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
> > Lines 1250 (patched)
> > <https://reviews.apache.org/r/66485/diff/5/?file=2005164#file2005164line1258>
> >
> > Why is this OK? The query produced no output?
This is the same commitJob in the compactor. I'm not sure if it can happen...
perhaps from a number of empty inserts/ctas?
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66485/#review201574
-----------------------------------------------------------
On April 18, 2018, 1:46 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66485/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 1:46 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b8d948d3d3
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java
> 82ba775286
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4acdd9b49b
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java c8cb8a40b4
> ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java dde20ed56e
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
> b1c2288d01
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
> 22765b8e63
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java fe0aaa4ff5
>
> standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/hive_metastoreConstants.java
> cb1d40a4a8
>
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java
> 7b02865e18
>
> storage-api/src/java/org/apache/hadoop/hive/common/ValidReaderWriteIdList.java
> 107ea9028a
>
>
> Diff: https://reviews.apache.org/r/66485/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
