----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66571/#review201050 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 2914 (patched) <https://reviews.apache.org/r/66571/#comment281994> It would be good to add these to "hive.conf.restricted.list" values metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql Lines 1306 (patched) <https://reviews.apache.org/r/66571/#comment281992> this is not easy to read where the parenthesis start and end, can you reformat with some indendation to make it easier to read ? ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveResourceACLs.java Lines 61 (patched) <https://reviews.apache.org/r/66571/#comment282003> EnumMap could be used for efficiency here ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java Lines 51 (patched) <https://reviews.apache.org/r/66571/#comment281993> the if/else can be replaced with - enabled = new BooleanWritable(HiveConf.getBoolVar(hiveConf, ConfVars.HIVE_SERVER2_RESTRICT_INFORMATION_SCHEMA) service/src/java/org/apache/hive/service/server/HiveServer2.java Lines 896 (patched) <https://reviews.apache.org/r/66571/#comment282004> does it have to also have dynamic sevice discovery enabled ? We could assume that if HIVE_SERVER2_PRIVILEGE_SYNCHRONIZER=true and namespace is set, zookeeper is setup appropriately. service/src/java/org/apache/hive/service/server/HiveServer2.java Lines 905 (patched) <https://reviews.apache.org/r/66571/#comment282005> call variable authorizer (not authorizor) ? - Thejas Nair On April 11, 2018, 10:33 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66571/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 10:33 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > See HIVE-19161 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0627c35 > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 801de7a > itests/hive-unit/pom.xml f473d25 > > itests/hive-unit/src/test/java/org/apache/hive/service/server/TestInformationSchemaWithPrivilege.java > PRE-CREATION > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 3444439 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java d59bf1f > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/PrivilegeSynchonizer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveResourceACLs.java > 53e221f > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6003ced > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCurrentGroups.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRestrictInformationSchema.java > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java 6308c5c > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 450da4f > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > ebbf465 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > b2c40c2 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 2056930 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > f6c46ee > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > c47856d > standalone-metastore/src/main/thrift/hive_metastore.thrift 7450439 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 304f567 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 85c6727 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClientPreCatalog.java > 7d37262 > > > Diff: https://reviews.apache.org/r/66571/diff/1/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
