----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66503/#review200741 -----------------------------------------------------------
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java Line 217 (original), 222 (patched) <https://reviews.apache.org/r/66503/#comment281590> If the catalogs.add(rawStore.getCatalog(catName)) is moved to another line, safer to use {} for a block under for loop. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java Lines 118 (patched) <https://reviews.apache.org/r/66503/#comment281591> I think we can just keep track of size of partitions in it (and perhaps tables) since that should be taking almost all the memory. I am just worried that SharedCache is more complicated structure, and we might hit bugs around such structures in estimation. There are whole lot of other basic classes that we don't estimate size of. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java Lines 1786 (patched) <https://reviews.apache.org/r/66503/#comment281593> In master the Validator impls have been moved to separate classes (recent commit I suppose). Can yo u also please add SizeValidator as a seperate class ? - Thejas Nair On April 9, 2018, 9:57 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66503/ > ----------------------------------------------------------- > > (Updated April 9, 2018, 9:57 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-19126 > https://issues.apache.org/jira/browse/HIVE-19126 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-19126 > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/IncrementalObjectSizeEstimator.java > 6f4ec6f1ea > > llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileEstimateErrors.java > 2f7fa24558 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestIncrementalObjectSizeEstimator.java > 0bbaf7e459 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > c47856de87 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java > 89b400697b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > 995137f967 > > > Diff: https://reviews.apache.org/r/66503/diff/1/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
