----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66368/ -----------------------------------------------------------
Review request for hive, Gopal V and Jesús Camacho Rodríguez. Bugs: HIVE-18609 https://issues.apache.org/jira/browse/HIVE-18609 Repository: hive-git Description ------- - Save ValidTxnWriteIdList when saving query to the results cache. - Compare the write ID list for each transactional table during results cache lookup. - Add configuration to determine if queries with non-transactional tables should be cached. Diffs ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8d9b5a3194 itests/src/test/resources/testconfiguration.properties 0d6aaae535 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 667f436a89 ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java 4fa1044232 ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 1828f0a531 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 26f20f2e05 ql/src/test/queries/clientpositive/results_cache_1.q 4aea60e1e5 ql/src/test/queries/clientpositive/results_cache_2.q 96a90925f6 ql/src/test/queries/clientpositive/results_cache_capacity.q 9f54577009 ql/src/test/queries/clientpositive/results_cache_empty_result.q 621367141e ql/src/test/queries/clientpositive/results_cache_invalidation.q PRE-CREATION ql/src/test/queries/clientpositive/results_cache_lifetime.q 60ffe96a04 ql/src/test/queries/clientpositive/results_cache_quoted_identifiers.q 4802f43ba9 ql/src/test/queries/clientpositive/results_cache_temptable.q 9e0de765cb ql/src/test/queries/clientpositive/results_cache_transactional.q PRE-CREATION ql/src/test/queries/clientpositive/results_cache_with_masking.q b4fcdd57eb ql/src/test/results/clientpositive/llap/results_cache_invalidation.q.out PRE-CREATION ql/src/test/results/clientpositive/llap/results_cache_transactional.q.out PRE-CREATION ql/src/test/results/clientpositive/results_cache_invalidation.q.out PRE-CREATION ql/src/test/results/clientpositive/results_cache_transactional.q.out PRE-CREATION Diff: https://reviews.apache.org/r/66368/diff/1/ Testing ------- qtests added. Thanks, Jason Dere