----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66116/#review199379 -----------------------------------------------------------
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java Lines 251 (patched) <https://reviews.apache.org/r/66116/#comment279693> Would better assign `list.get(i)` to a tmp variable so that we don't have iterate the list again to get the item if it exists hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java Line 296 (original), 298 (patched) <https://reviews.apache.org/r/66116/#comment279694> ditto on `list.get` - Yibing Shi On March 16, 2018, 10:57 p.m., Oleksiy Sayankin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66116/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 10:57 p.m.) > > > Review request for hive, Aihua Xu, Yongzhi Chen, and Yibing Shi. > > > Repository: hive-git > > > Description > ------- > > Initial commit > > > Diffs > ----- > > hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseRowSerializer.java > be6aa1e2f8 > hbase-handler/src/test/queries/positive/hbase_queries.q 43efd6c7d2 > hbase-handler/src/test/results/positive/hbase_queries.q.out 8fcd350918 > > > Diff: https://reviews.apache.org/r/66116/diff/1/ > > > Testing > ------- > > > Thanks, > > Oleksiy Sayankin > >
