----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review199027 -----------------------------------------------------------
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java Lines 372 (patched) <https://reviews.apache.org/r/65985/#comment279313> why when db name is changed at alter table, the transactionalListenerResponses is not past into MetaStoreListenerNotifier.notifyEvent()? And the command won't be able to block until sentry gets the notification of alter table. - Na Li On March 8, 2018, 4:11 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65985/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 4:11 p.m.) > > > Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18783 > https://issues.apache.org/jira/browse/HIVE-18783 > > > Repository: hive-git > > > Description > ------- > > HIVE-16164 introduced a mechanism to pass HMS notification events ID to the > post-commit listeners for all DDL operations, but it didn't add it to the > ALTER TABLE event. This patch in review adds the same behavior for ALTER > TABLE events. > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > e0e29652da94bbdaca515a17955d1409824c1742 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 89354a2d34249903a9ff13c4ed913a68de93057e > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 662de9a66767f27f31998f14c68f854e59993ab6 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IHMSHandler.java > e6de00100003bc1be12b2772e2e97102ed476cf5 > > > Diff: https://reviews.apache.org/r/65985/diff/1/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Sergio Pena > >
