> On March 8, 2018, 2:15 a.m., Alexander Kolbasov wrote: > > Afrew with Sahil - the checks should be on the server side.
Thanks a lot Sasha for the review! I absolutely agree that it would be better to have the checks on the server side, however these checks have to be done in the client, because the NPE occurs before calling HiveMetaStore. As I wrote above, the PartitionDropOptions parameter is not sent to HiveMetaStore. In HiveMetaStore we only have the boolean values which are set in PartitionDropOptions and the NPE occurs when trying to get these variables. With a part_vals list which has null values, the NPE occurs when thrift is trying to serialize it. So we should do the check before calling the thrift method. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/#review198847 ----------------------------------------------------------- On March 7, 2018, 3:48 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65952/ > ----------------------------------------------------------- > > (Updated March 7, 2018, 3:48 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18898 > https://issues.apache.org/jira/browse/HIVE-18898 > > > Repository: hive-git > > > Description > ------- > > The TestDropPartitions tests revealed that NPE is thrown if the > dropPartition(String db_name, String tbl_name, List<String> part_vals, > PartitionDropOptions options) method is called with null options and with a > part_vals list which contains null elements. > > > Diffs > ----- > > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 3128089 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > 4d94ebf > > > Diff: https://reviews.apache.org/r/65952/diff/1/ > > > Testing > ------- > > Run the TestDropPartitions tests. > > > Thanks, > > Marta Kuczora > >
