----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65250/#review197423 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 677-680 (patched) <https://reviews.apache.org/r/65250/#comment277583> catch (MetaException | TException) is more concise. ql/src/java/org/apache/hadoop/hive/ql/parse/MaterializedViewRebuildSemanticAnalyzer.java Lines 79 (patched) <https://reviews.apache.org/r/65250/#comment277584> This looks like implementation bug. Should assert false here. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Line 3749 (original), 3765 (patched) <https://reviews.apache.org/r/65250/#comment277578> Reading your name in log file may cause some panic to hive admins :) Chage to LOG.trace () ? - Ashutosh Chauhan On Feb. 8, 2018, 10:34 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65250/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 10:34 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18387 > https://issues.apache.org/jira/browse/HIVE-18387 > > > Repository: hive-git > > > Description > ------- > > HIVE-18387 > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java > 78b26374f21a914d1b5681788b7b936b0d9c9296 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java > d763666ab308a48456a1aebe2c94434ba3bc3fcd > ql/src/java/org/apache/hadoop/hive/ql/QueryLifeTimeHookRunner.java > 53d716bceb98c2ced3a3ba3f0cd607766447dfd9 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 20c2c3294ab638b0d5284b9d24865f901ab6d033 > > ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewUpdateRegistryTask.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/MaterializedViewUpdateRegistryWork.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java > 85cef8664674db72cd69929d4ad96f1bd85279da > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > c8d1589f44c4443a64d0701260bb4850eeeab233 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > 69447d9d3412fefc37d0495dd4c96df974f08927 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 8a1bfd21b45671e8fc183bcce5b028e8ece3e21b > > ql/src/java/org/apache/hadoop/hive/ql/parse/MaterializedViewRebuildSemanticAnalyzer.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java > 4c41920cba2b8b03871a73e8ae6c006853a657b6 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 8e587f1cf6d1d224fe001df9ec89201573716033 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 2e1f50e641c297914831ec1e4de2c6304408cca1 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java > 92d29e3a576ad95874f312d3371b494976b59399 > ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java > aef83b83e19bdba90edabde8534b5ef8f7bd40bd > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > b48379013d74c56df245bb9e292e45bb298367da > ql/src/test/queries/clientpositive/druidmini_mv.q > e0593576020af7dd5cc26dd613395d6cde72496e > ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q > efc65c4061c608fac5ba308a9a8238aca443555f > ql/src/test/results/clientpositive/druid/druidmini_mv.q.out > 5a0b885f7759d013eb6b1e5d411f02e9c4d4468b > ql/src/test/results/clientpositive/materialized_view_create_rewrite_3.q.out > 0d8d238e8b43fdf453f3c11cd1cdd0f1aa8764bc > ql/src/test/results/clientpositive/materialized_view_create_rewrite_4.q.out > 8ab151718668daa8915575ffed5845d62e15b775 > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h > bfa17eb3e64ab69de57c65b8759dca816256677f > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp > af0fd6b0e06694f9a9cb5a94edb1c2a91c819650 > > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp > cf9a1713aa9ba63b0b7f813fe68d7f75b5ee7c47 > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h > 4c09bc8fe642f6c43d21d5e373795001bc34189a > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp > aadf8f17c452cafccd85133364af6edb8a5587a5 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Materialization.java > b399d664229c9532f4cfbaeb680c4753902bdf36 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > d5e3527d09ced377141b0585f55a1df9647aa4ac > > standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php > 9382c60120cecfe067ff6e9ac495eb23ac73168f > standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php > a5b578ef37acc834cc96212de66b5217655a2e49 > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > 9b2aaffd0fa5b63adcbebb37037452f1de9a378f > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 2e1910568a30f6aa74ab2054cb27a573fb1a8a59 > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 5598859042547daa553120fc92502a2dbe0f5f95 > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb > bc58cfe0efb767b5cafb2a2f946c688045d405e8 > standalone-metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb > ec8813130851181e36a1a840862415c9a28b00b5 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 8dc9b6af92359460b732fb47d8e590329dbc91c0 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 23cef8d556ed299612d7cbb66074f9975751e034 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 96d4590222286d44d1b5508b74deba8166e2c5dd > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationInvalidationInfo.java > f787dd415588b0c8db432779695cfbbf8e350311 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java > 20e4e8db5137ca92857c0a078a22e16e92107b9e > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > d58ed677f3bc71ede0461c6852ce19c23eb446bc > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java > e4e7d4239d65ed3ff6991ca54fedccd5a8a8e905 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > 80aa3bcdb44e654f0b2ac224ae8e37eb00d3ced4 > standalone-metastore/src/main/thrift/hive_metastore.thrift > 371b97590c3ea2d9c3729457a4ff794ecdfbc05c > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 9100c73bebb37ea10c23e4ea5d031152ad41c7d1 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 86e72d8d7610148c70e656f35093be9ad0247202 > > > Diff: https://reviews.apache.org/r/65250/diff/4/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
