> On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 1238 (patched) > > <https://reviews.apache.org/r/65342/diff/3/?file=1950838#file1950838line1243> > > > > If its a MV, all metadata related to it is erased. Thats good. But if > > its a table participating in MV, then should dropping of such table also > > result in automatic drop of all MV its part of? Not sure how other DBs > > handle it. But we should note this in comments here.
I planned to create a follow-up for this. Maybe failing unless using a cascade option? I will check how it is done in other RDBMs. > On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Line 1914 (original), 1945 (patched) > > <https://reviews.apache.org/r/65342/diff/3/?file=1950838#file1950838line1950> > > > > Shall we do validation of length for txnlist and throw if its bigger? If we try to write a txnList longer than the CLOB supported size for the backing RDBMs, the write will fail. I will specify the length of the CLOB at the RDBMs DDL level so limit is exactly the same for all metastore RDBMs. Introducing the limit check here seems redundant, since write will fail. What do you think? > On Feb. 2, 2018, 1:31 a.m., Ashutosh Chauhan wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCreationMetadata.java > > Lines 22 (patched) > > <https://reviews.apache.org/r/65342/diff/3/?file=1950839#file1950839line22> > > > > Good to javadoc for class. I will, thanks. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65342/#review196673 ----------------------------------------------------------- On Jan. 31, 2018, 12:07 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65342/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 12:07 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-18546 > https://issues.apache.org/jira/browse/HIVE-18546 > > > Repository: hive-git > > > Description > ------- > > HIVE-18546 > > > Diffs > ----- > > metastore/scripts/upgrade/derby/048-HIVE-14498.derby.sql > 4ffd054530503681de1c9f6d65f8187fc1b7520d > metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql > 6a59b0df712c8a9f9be880cec5fd8c8eddda4a7d > metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql > d72b06cb5866edf93dbcbb20268fc899439e5c43 > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql > eb4f0124b5a7829e58d5e9a6a604c201ccea998a > metastore/scripts/upgrade/mssql/033-HIVE-14498.mssql.sql > 3a47600bb09e2c20cc12f8759e1287001367604e > metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql > c45bb3e323c640223b19831abbf4e806c3019f0b > metastore/scripts/upgrade/mysql/048-HIVE-14498.mysql.sql > 986eaf5272eab560fa2f862910aaf74c5332c716 > metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql > 01c995d632d94a8f9cc3f46f94c54290abb3da13 > metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql > 497846f994d431d8717aea36d4ad569892e3c8c3 > metastore/scripts/upgrade/oracle/048-HIVE-14498.oracle.sql > 0b01e89d92f7f48439024aeb326d675d123f0f8c > metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql > e1aee6fb6c84999b17f87f80750582fafeae063f > metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql > 5411bc47103f901623244bc26c0ace87e10ad2e1 > metastore/scripts/upgrade/postgres/047-HIVE-14498.postgres.sql > 8d4de8870d93bab49c873cab44e6714b93491744 > metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql > 28cb01684a46aaeea40d7cbe1973d7bc20810988 > metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql > a81d6eec6d6235706f1225d541f8290971cc6215 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > 51ef39057434c41fbe760c547e3bf231e65e4cc0 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java > 9b0ffe0e91db05ae623531248f12745266789a11 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > d159e4bed1cd4ff04bed1c397318bc2951c02a51 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > dbf9363d11deea5377808094d7cb3331ee0f999f > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java > 97baf25ea8bbe6f55e46e2ea5bdf33a5a71eecdf > ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java > 3535fa4d02106f4e96af6c33ffa291c8db21e3bc > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java > aa95d2fcdcd0b3cede35537a1d7d041ee738e4a8 > ql/src/test/results/clientpositive/llap/sysdb.q.out > 5ed427fd2aa6fbb83877031e6692bd8f1994730d > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h > 42bc9297e72ac8fd77352cb786cfed3abf5af59b > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp > 8b78230a32d4d4339189c1db4b533ed04ec080af > > standalone-metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp > 6a2ff6c4c681b2dbaf339b214663212a2e6dab22 > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h > df646a7d1771892e4404be5c4fba183c0f914510 > standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp > 27f8c0f2fcb24a90be8a44d68947589004286c28 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AbortTxnsRequest.java > 398f8d4e93c6077c110e6469bcd3715fdad5a634 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java > 2102aa5215598edfe5e5c53d541c4fe02ebc7f09 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddForeignKeyRequest.java > a2225298e72f708e97324048592c37a308e43514 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddNotNullConstraintRequest.java > ef23d3025aabb2934f93230ea72c4585dda973e4 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java > 13a23182488ebda9ab0f7163fd4d6822c04c975f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java > 49ce6e1a6cc38994662f56536c6dd6bd55e67d47 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPrimaryKeyRequest.java > 478032a987e7688741fe55b9732f5ec0e8fc209f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddUniqueConstraintRequest.java > b58f39f7b045f3dbaf95df9e28190517280bd8c4 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java > 54ef01f3ce4448f0b404772a30a5b0d61641e3c2 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/BasicTxnInfo.java > f695e5d9bd4f96ff5a3d5b055a05ac00574ce01b > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java > dbda2ab74128a698452f639b6a7b142b47ca351b > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClientCapabilities.java > 0df33f1c8b29f9dfd94815e0d7bcf6a841e54043 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java > 962bb1cc1702a6e2463751ac83ef3e58c663af93 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CompactionRequest.java > b92293e6a7cd5ffc9a871784a382a6351c1c122b > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/CreationMetadata.java > PRE-CREATION > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java > 83ff494ce443a8ec45e0132878d8680969c32a71 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java > d7c4febc877d452fa19ac84a65ec23e64b33188d > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java > 4efec9d7b9a42f3779727ddba4c273cba1d376eb > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java > 2b921c508150d8f77cfabc8b9a7a9ffd50298b24 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java > 0f5d5ebb3c228b7cd381812a6f8926e6497309ec > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java > bff424fe1538cb5b98cc206359b9a49f88e282f6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java > 38a5ed9d103a129699932eaf3c3553fdffd32c97 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java > a3dc7436f3172fff28ecab75b3129ed04615cae6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java > 53603afce32910f39dfa8d3010a1e7c71923986d > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java > 440965ed966934fad02a3b592a88b417b6f4d1d7 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java > a77f661b7d5c8b196694c3ca072e8340354ece68 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java > 70ea1de7d31ea7d7a405d6bab0122e5078757333 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesRequest.java > 575737dc677304ac7edfbbeb9f0d5a7332203a7f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetTablesResult.java > 050d093d845a3f03d9be5efd8ee1eb35c5828c8f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java > 828e94e9e205ea4e230efc236d8b297704e3a60d > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java > 556e7c672972c409a8dd0aa61119949d7b04e482 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java > 184f9d52a5c66c81b373e969aceafd542c349b98 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java > b5d17cc0fff36f777ffb881cc88cc82cc080d013 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Materialization.java > f217bf002894e53ae109af1d630848b3e15d8ca6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotNullConstraintsResponse.java > 3257a411f62651726fea409e406a5f651b0d684b > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java > eb578449ec3212ee20f9c8c6ca1fae0e9b7dcb75 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java > d1a1bf87886a1419f15435322a50e762ef978197 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java > 7ec61722e93f999f8382770ce66e2fdb688f1d56 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java > 17b6c44cf2b4e89347f25a960a164ce786b0b836 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java > 71bd08b48a8cfd218c807aa936bc382fec9f6c61 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRequest.java > 9db256d9bbb66dd0f62da4bbf43a7258a05f5ff6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesResponse.java > 278118045a45be9a23192859d3dc843173b88164 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionValuesRow.java > 595f35044b4b3e7c173ad329f789003f8daaa091 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java > 1f5d31491fc7993fbcdf1b4db2d740c1914f4595 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java > 9be6b48d2793df4198290028760f97c639148e2f > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java > 80910f81575068130bb2882780770df3279c0e53 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java > 41408eb244903fd079b1f4bab6d77cedd121485d > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java > 8005270e71921256790f384ddcba37f62debd2e6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java > 5896fd9476920448bc40aff8b7a981a88547938c > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java > f9c237091ff2c865732b5485ca46639c1add2513 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java > c95216feadedfeabe41c5b178849bf9917c85b34 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java > f4a66ed7af6e2682838bd4081f2e39b43931a196 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java > 1b506024f9424d336271f48505406d1300ef2ec6 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java > a21a191b1d4d6e3d5b61462533b64ded16b4a046 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java > f317b0393f07a85f62cf89548ca9a7e024619df2 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java > 575fa9f852a6b5a6194d82aab7467908da6ee906 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java > 32aeb9db7ec0c10ac09744621ece93a02ff67968 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java > aaca40873cfa76d6da1806dc7f5cc75432b9c880 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TxnsSnapshot.java > 5600bdadc4cdb7394a759c53af40274cd67aa870 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/UniqueConstraintsResponse.java > 342e6b0e131f3e3ba5afa79f8402e44bf211434e > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMFullResourcePlan.java > c9988c02291768f2ccc9328da0d600ebe83735af > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java > fb96ad959b13e94926f0d2d7722598421716f2cf > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java > 4d4894a7132c39dc07054813656ff862f35a99a4 > > standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMValidateResourcePlanResponse.java > ea8f3aaf643f13d850caded44e5462a6a4b10c35 > > standalone-metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php > bf7d4664920d5156490fe58bd9276b4733d273d3 > standalone-metastore/src/gen/thrift/gen-php/metastore/Types.php > 6878ee1be7f25ebda410ba307708139802a609ea > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote > a8fcea6380da02ba0d528ce43949ac7dddefdf96 > > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py > 988c01a06b10e5a552b5410f7debe29760bf724a > standalone-metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py > 25e9a889b220326956c352a14692bb34ec5eb14e > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb > 3a11a0582ab70cfe9f39938beff6b605bca2c944 > standalone-metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb > a788c0885395afb2f44d8fb089678c89d92e1f34 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ecc464418df8f60b60a18e934400138f209cf51b > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 3a468b108a554e65499e37bc4f0c60592754c752 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 8ec8b3ba082565df7dfa80f9f66c179239a1fe3d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java > de912d5630ec04f0d0f7c1ac059d6acec92e9bcc > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > b3d99a1da591d52c5068a433bf8c3b8e42347082 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MCreationMetadata.java > PRE-CREATION > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MTable.java > 6c40ae87536e85e0aac5fe05c9f71daea38352f8 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 3a558b4ac486cf45cb3d0d397da5777410e8f61d > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStore.java > 42f90cdb66b73b0ad29475a08c3d638370602456 > standalone-metastore/src/main/resources/package.jdo > 3da09a5ebbb100d5bd630a9e325d528dd79e90cb > standalone-metastore/src/main/thrift/hive_metastore.thrift > 93f3e53de2969af77c5c4eb7e6a2c416b5886565 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java > b9a8f61c691d3e8cd0bab6b3313f2099b9107ff4 > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > abc400a928dca5c7401076b105af200b481861bc > > > Diff: https://reviews.apache.org/r/65342/diff/3/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
