> On Jan. 30, 2018, 3:09 a.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 3821 (patched) > > <https://reviews.apache.org/r/65276/diff/1-2/?file=1944274#file1944274line3821> > > > > So only non-bucketed ACID tables get the file rename to 000000_0 etc? > > What happens with bucketed ACID tables and the file name?
Yes. As mentioned the change summary, the logic for bucketed ACID tables is part of the larger work I am doing for bucketed tables in general. > On Jan. 30, 2018, 3:09 a.m., Jason Dere wrote: > > ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out > > Lines 29 (patched) > > <https://reviews.apache.org/r/65276/diff/1-2/?file=1944280#file1944280line29> > > > > Is there a smaller table/results you can test with? The idea was to actually see if we get results or not. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196499 ----------------------------------------------------------- On Jan. 29, 2018, 11:10 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65276/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 11:10 p.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-18516 > https://issues.apache.org/jira/browse/HIVE-18516 > > > Repository: hive-git > > > Description > ------- > > load data should rename files consistent with insert statements for ACID > Tables. > Includes test change for a missed test. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties d86ff58840 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 5868d4dd56 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java > c6a4a8926b > ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION > ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 > ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out > PRE-CREATION > ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 > ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 > > > Diff: https://reviews.apache.org/r/65276/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
