----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196430 -----------------------------------------------------------
Nice patch with well covered cases. Since this is a lot of test code, wouldn't it make sense to move the PartitionSpec-related code into a separate class (rather than having a 2k+ LOC class)? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java Lines 2220-2221 (patched) <https://reviews.apache.org/r/65380/#comment276059> 123456 may be a contant to be considered for extraction - Adam Szita On Jan. 29, 2018, 12:27 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65380/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 12:27 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18566 > https://issues.apache.org/jira/browse/HIVE-18566 > > > Repository: hive-git > > > Description > ------- > > he following methods of IMetaStoreClient are covered by this test. > - int add_partitions_pspec(PartitionSpecProxy) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > 09be321 > > > Diff: https://reviews.apache.org/r/65380/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
