----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65353/#review196416 -----------------------------------------------------------
Thanks for the patch Adam. I was only be able to come up 1 more test case :) standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetTableMeta.java Lines 144 (patched) <https://reviews.apache.org/r/65353/#comment276033> It might be a good idea to add a comment field to some of the tables. And leave out the comment field for others, and check the results too. - Peter Vary On Jan. 26, 2018, 6:12 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65353/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2018, 6:12 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18542 > https://issues.apache.org/jira/browse/HIVE-18542 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover getTableMeta method > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetTableMeta.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65353/diff/1/ > > > Testing > ------- > > Have run the tests themselves > > > Thanks, > > Adam Szita > >
