> On Jan. 26, 2018, 7:55 p.m., Vihang Karajgaonkar wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 8236 (patched) > > <https://reviews.apache.org/r/65330/diff/1/?file=1946171#file1946171line8236> > > > > Does this work when there are multiple HMS instances?
Yes. The fix is semantically identical to the Hive 3.0 fix - it uses SELECT FOR UPDATE to get a row lock on the NOTIFICATION_SEQUENCE table single row. > On Jan. 26, 2018, 7:55 p.m., Vihang Karajgaonkar wrote: > > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > > Lines 442 (patched) > > <https://reviews.apache.org/r/65330/diff/1/?file=1946172#file1946172line451> > > > > does this need to say "It assumes that no other thread does any > > modifications..." this is a typo, should be "notifications" > On Jan. 26, 2018, 7:55 p.m., Vihang Karajgaonkar wrote: > > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > > Lines 471 (patched) > > <https://reviews.apache.org/r/65330/diff/1/?file=1946172#file1946172line480> > > > > is this needed? Yes, doesn't work without it. > On Jan. 26, 2018, 7:55 p.m., Vihang Karajgaonkar wrote: > > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > > Lines 534-535 (patched) > > <https://reviews.apache.org/r/65330/diff/1/?file=1946172#file1946172line543> > > > > do we need this since we asserting oldVal is always null above? Technically not, we can just rely on assert to do the check. I am not exactly sure how these asserts work when run in a separate thread. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65330/#review196365 ----------------------------------------------------------- On Jan. 25, 2018, 1:38 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65330/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2018, 1:38 a.m.) > > > Review request for hive, anishek, Andrew Sherman, Janaki Lahorani, Sergio > Pena, Sahil Takiar, Thejas Nair, and Vihang Karajgaonkar. > > > Bugs: HIVE-18526 > https://issues.apache.org/jira/browse/HIVE-18526 > > > Repository: hive-git > > > Description > ------- > > HIVE-18526 Backport HIVE-16886 to Hive 2 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > d16d2a3cd6a08217bb5b5b7bd9226f5e19f68994 > metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java > 69e8826f53c9278a7307817c8bfa4151f36631b9 > > > Diff: https://reviews.apache.org/r/65330/diff/1/ > > > Testing > ------- > > I wrote unit test which runs against stand-alone DB and verified that > everything is as expected. > > > Thanks, > > Alexander Kolbasov > >
