----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196018 -----------------------------------------------------------
Just 2 more test cases I can come up with. Is it worth to create a test case for them? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java Lines 200 (patched) <https://reviews.apache.org/r/65285/#comment275537> Maybe test for case insensitivity? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java Lines 236 (patched) <https://reviews.apache.org/r/65285/#comment275538> Maybe test for no db? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java Lines 305 (patched) <https://reviews.apache.org/r/65285/#comment275539> Maybe test for no database? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java Lines 347 (patched) <https://reviews.apache.org/r/65285/#comment275540> Maybe test for case insensitivity? - Peter Vary On Jan. 23, 2018, 9:42 a.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65285/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 9:42 a.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18483 > https://issues.apache.org/jira/browse/HIVE-18483 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover getPartition(s) methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65285/diff/1/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
