----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196003 -----------------------------------------------------------
Fix it, then Ship it! Looks good Peter, thanks for the patch! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 103 (patched) <https://reviews.apache.org/r/65210/#comment275513> Should we extract "org.apache.hadoop.hive.ql.udf.generic.GenericUDFUpper" into a constant as it is used multiple times here? - Adam Szita On Jan. 22, 2018, 2:33 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 2:33 p.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
