----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review195979 -----------------------------------------------------------
Thanks a lot Peter for the patch. I looks really good to me, I have only one comment. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java Lines 285 (patched) <https://reviews.apache.org/r/65264/#comment275449> Might worth to add a test with empty filter. - Marta Kuczora On Jan. 22, 2018, 3:38 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65264/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 3:38 p.m.) > > > Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. > > > Bugs: HIVE-18481 > https://issues.apache.org/jira/browse/HIVE-18481 > > > Repository: hive-git > > > Description > ------- > > Create IMetaStoreClient tests to cover the table query methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65264/diff/2/ > > > Testing > ------- > > Run the created tests > > > Thanks, > > Peter Vary > >
