> On Jan. 17, 2018, 11:10 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > > Line 157 (original), 183 (patched) > > <https://reviews.apache.org/r/65173/diff/3/?file=1941302#file1941302line185> > > > > Callers of this has conf as well.
In this case, we could use it indeed. However, should we use the conf for the Session when we create the MV or a fresh conf associated with HS2? - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65173/#review195657 ----------------------------------------------------------- On Jan. 17, 2018, 10:52 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65173/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 10:52 p.m.) > > > Review request for hive, Ashutosh Chauhan and Thejas Nair. > > > Bugs: HIVE-18386 > https://issues.apache.org/jira/browse/HIVE-18386 > > > Repository: hive-git > > > Description > ------- > > HIVE-18386 > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java > 2cd3c95dc996671f4b176ab44f8584f039537e5f > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > f2e927f9a2a7a4cb06481ccd15d3cf5d0a9ac24b > data/conf/hive-site.xml 9f6aec178d968ee5183ee36824426ea50d3abe62 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 9b102f2a367f04b83e886e231b09f92e6be14088 > > ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryPropertiesHook.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > 7e5c81b6fd9a3264579585dd2043a27e7df72b4e > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 80c7804dc1c40efecb61d28d4bb15da14c427054 > ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q > PRE-CREATION > > ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q > PRE-CREATION > > ql/src/test/results/clientpositive/materialized_view_create_rewrite_dummy.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q.out > PRE-CREATION > service/src/java/org/apache/hive/service/server/HiveServer2.java > 58b8fb42f2d4c875333a2257f859d32853292002 > > > Diff: https://reviews.apache.org/r/65173/diff/4/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
