----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65009/#review194973 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java Lines 171 (patched) <https://reviews.apache.org/r/65009/#comment274070> It would be nice to include db.table name in all these messages/exceptions - much easier to interpret production logs. ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java Lines 210 (patched) <https://reviews.apache.org/r/65009/#comment274071> should this check that it has seen all bucket files? what if bucketN is missing? Would that be an issue downstream? Maybe only do that on MR or only in strict mode.... - Eugene Koifman On Jan. 8, 2018, 7:29 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65009/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 7:29 p.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Repository: hive-git > > > Description > ------- > > load data should rename files consistent with insert statements (bucketed > tables only) > > Moved some data files to subdirectories to maintain names in 000000_0 format. > Some files are used in tests with non-bucketed tables, so they are copied > instead. > > > Diffs > ----- > > data/files/auto_sortmerge_join/big/000000_0 PRE-CREATION > data/files/auto_sortmerge_join/big/000001_0 PRE-CREATION > data/files/auto_sortmerge_join/big/000002_0 PRE-CREATION > data/files/auto_sortmerge_join/big/000003_0 PRE-CREATION > data/files/bmj/000000_0 PRE-CREATION > data/files/bmj/000001_0 PRE-CREATION > data/files/bmj/000002_0 PRE-CREATION > data/files/bmj/000003_0 PRE-CREATION > data/files/bucketed_files/000000_0 PRE-CREATION > data/files/bucketed_files/000001_0 PRE-CREATION > data/files/smallsrcsortbucket1outof4.txt > data/files/smallsrcsortbucket2outof4.txt > data/files/smallsrcsortbucket3outof4.txt > data/files/smallsrcsortbucket4outof4.txt > data/scripts/q_test_init.sql 01d6d4c9dd > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 4535c3edc2 > ql/src/test/queries/clientnegative/bucket_mapjoin_mismatch1.q 7b207c647d > ql/src/test/queries/clientnegative/dynamic_partitions_with_whitelist.q > e6b7a9f59a > ql/src/test/queries/clientnegative/insertover_dynapart_ifnotexists.q > 173dbd04aa > ql/src/test/queries/clientpositive/autoColumnStats_1.q cc32393e65 > ql/src/test/queries/clientpositive/autoColumnStats_2.q de86036bfb > ql/src/test/queries/clientpositive/auto_sortmerge_join_1.q a044c6d2d0 > ql/src/test/queries/clientpositive/auto_sortmerge_join_11.q 1393351ba6 > ql/src/test/queries/clientpositive/auto_sortmerge_join_12.q cfaef76542 > ql/src/test/queries/clientpositive/auto_sortmerge_join_16.q 12ab1fa1d1 > ql/src/test/queries/clientpositive/auto_sortmerge_join_2.q 122bba5380 > ql/src/test/queries/clientpositive/auto_sortmerge_join_3.q fa6e0afd9b > ql/src/test/queries/clientpositive/auto_sortmerge_join_4.q 3540779c17 > ql/src/test/queries/clientpositive/auto_sortmerge_join_5.q 8ca04d61ff > ql/src/test/queries/clientpositive/auto_sortmerge_join_7.q 5a16d8cbfe > ql/src/test/queries/clientpositive/auto_sortmerge_join_8.q 4ae7b1da61 > ql/src/test/queries/clientpositive/bucket_map_join_spark1.q 9018b4e89d > ql/src/test/queries/clientpositive/bucket_map_join_spark2.q 6f54737e2f > ql/src/test/queries/clientpositive/bucket_map_join_spark3.q 26a8d48486 > ql/src/test/queries/clientpositive/bucket_map_join_tez1.q 2231493637 > ql/src/test/queries/clientpositive/bucket_map_join_tez2.q 2ce859f7c6 > ql/src/test/queries/clientpositive/bucketcontext_1.q 2ac2aa7f8d > ql/src/test/queries/clientpositive/bucketcontext_2.q b8955fe196 > ql/src/test/queries/clientpositive/bucketcontext_3.q cf9d6e9ba6 > ql/src/test/queries/clientpositive/bucketcontext_4.q c41f94423d > ql/src/test/queries/clientpositive/bucketcontext_5.q 689a4a5338 > ql/src/test/queries/clientpositive/bucketcontext_6.q 2b5ca587d5 > ql/src/test/queries/clientpositive/bucketcontext_7.q abbf07caf0 > ql/src/test/queries/clientpositive/bucketcontext_8.q bff938cd16 > ql/src/test/queries/clientpositive/bucketizedhiveinputformat_auto.q > 851690930e > ql/src/test/queries/clientpositive/bucketmapjoin1.q ee27181d58 > ql/src/test/queries/clientpositive/bucketmapjoin10.q c2f31559f7 > ql/src/test/queries/clientpositive/bucketmapjoin11.q f15389aa12 > ql/src/test/queries/clientpositive/bucketmapjoin12.q dcf3991ea8 > ql/src/test/queries/clientpositive/bucketmapjoin2.q 3a9816baba > ql/src/test/queries/clientpositive/bucketmapjoin3.q 495d3a4a8c > ql/src/test/queries/clientpositive/bucketmapjoin4.q ab9080cc8a > ql/src/test/queries/clientpositive/bucketmapjoin5.q 59ad98c827 > ql/src/test/queries/clientpositive/bucketmapjoin7.q 43cc19bb9b > ql/src/test/queries/clientpositive/bucketmapjoin8.q ecfe5973ed > ql/src/test/queries/clientpositive/bucketmapjoin9.q b7d3f6b5be > ql/src/test/queries/clientpositive/bucketmapjoin_negative.q 9f6858442b > ql/src/test/queries/clientpositive/bucketmapjoin_negative2.q 0dbd4aaaeb > ql/src/test/queries/clientpositive/bucketmapjoin_negative3.q b08d22e649 > ql/src/test/queries/clientpositive/cbo_rp_udaf_percentile_approx_23.q > c7e6755679 > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction_2.q > 97b3d84339 > ql/src/test/queries/clientpositive/explainanalyze_2.q dd515ec5cc > ql/src/test/queries/clientpositive/explainanalyze_3.q 6a5e3b33c6 > ql/src/test/queries/clientpositive/explainuser_2.q ef0e31beb1 > ql/src/test/queries/clientpositive/explainuser_3.q 9c6c9dc64c > ql/src/test/queries/clientpositive/mergejoin.q 8a28c5a194 > ql/src/test/queries/clientpositive/optimize_filter_literal.q d13197ad40 > ql/src/test/queries/clientpositive/smb_mapjoin_1.q b2394ad10f > ql/src/test/queries/clientpositive/smb_mapjoin_10.q ab8258f60b > ql/src/test/queries/clientpositive/smb_mapjoin_2.q 1b184d8629 > ql/src/test/queries/clientpositive/smb_mapjoin_25.q 44da19b113 > ql/src/test/queries/clientpositive/smb_mapjoin_3.q ecd38cc6e4 > ql/src/test/queries/clientpositive/smb_mapjoin_4.q 4e3fcaebf1 > ql/src/test/queries/clientpositive/smb_mapjoin_5.q 0decdaffd4 > ql/src/test/queries/clientpositive/stats11.q 6cf6d545ee > ql/src/test/queries/clientpositive/tez-tag.q 3ab477e068 > ql/src/test/queries/clientpositive/tez_fsstat.q 22e46fe2f8 > ql/src/test/queries/clientpositive/tez_smb_1.q 1ae35ef4bc > ql/src/test/queries/clientpositive/tez_smb_empty.q 8b3211d17f > ql/src/test/queries/clientpositive/tez_smb_main.q 6bace67d74 > ql/src/test/queries/clientpositive/udaf_percentile_approx_20.q 30052ebb0b > ql/src/test/queries/clientpositive/udaf_percentile_approx_23.q 8c66726563 > ql/src/test/results/clientnegative/dynamic_partitions_with_whitelist.q.out > cb5ee9b743 > ql/src/test/results/clientnegative/insertover_dynapart_ifnotexists.q.out > a40ffabba7 > ql/src/test/results/clientpositive/autoColumnStats_1.q.out e04eaf4530 > ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out cacc3d45e5 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_1.q.out 8ca2c339c7 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_2.q.out 7dcc26b5b3 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_3.q.out 7b4e491c22 > ql/src/test/results/clientpositive/bucketcontext_5.q.out d42dbef31e > ql/src/test/results/clientpositive/bucketizedhiveinputformat_auto.q.out > 215efdd2c6 > ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out 441d59a6c8 > ql/src/test/results/clientpositive/cbo_rp_udaf_percentile_approx_23.q.out > 4a2369d422 > ql/src/test/results/clientpositive/llap/autoColumnStats_1.q.out f93f666542 > ql/src/test/results/clientpositive/llap/autoColumnStats_2.q.out 0cc0c051fd > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out > 3c3e913076 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out > d6ecf9c0f5 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out > 2cebc0d02f > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_16.q.out > cb8564fd78 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out > ece7cfec3a > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out > 26613100a2 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out > 87d65ffc5b > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_5.q.out > 68b69e8ccd > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out > 3305c4d5c1 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out > 8362c8e24f > ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out > 4df0d41fd7 > ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out > b84edde144 > ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out df7d77e811 > ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out 04e104fab8 > ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out 297e1c8129 > ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out c07f722f5b > ql/src/test/results/clientpositive/llap/bucketmapjoin7.q.out f3a1c11aa9 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out > e2e2ef3861 > ql/src/test/results/clientpositive/llap/explainanalyze_2.q.out 55f3a780b1 > ql/src/test/results/clientpositive/llap/explainuser_2.q.out 4f8e327004 > ql/src/test/results/clientpositive/llap/smb_mapjoin_4.q.out 92acf4b16e > ql/src/test/results/clientpositive/llap/smb_mapjoin_5.q.out d7a75a3972 > ql/src/test/results/clientpositive/llap/stats11.q.out b9b2d5f469 > ql/src/test/results/clientpositive/llap/tez_fsstat.q.out 30ab50ba9b > ql/src/test/results/clientpositive/llap/tez_smb_1.q.out a486b13f96 > ql/src/test/results/clientpositive/llap/tez_smb_empty.q.out 1851428caa > ql/src/test/results/clientpositive/llap/tez_smb_main.q.out f45781423d > ql/src/test/results/clientpositive/mergejoin.q.out b6b22f4233 > ql/src/test/results/clientpositive/optimize_filter_literal.q.out ad7e0a418d > ql/src/test/results/clientpositive/smb_mapjoin_1.q.out 2e0f55b575 > ql/src/test/results/clientpositive/smb_mapjoin_2.q.out 7dcc26b5b3 > ql/src/test/results/clientpositive/smb_mapjoin_25.q.out 8e95f71f50 > ql/src/test/results/clientpositive/smb_mapjoin_3.q.out 7b4e491c22 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_16.q.out > cb8564fd78 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_5.q.out > 8e28cd181f > ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out > 461c7da44b > ql/src/test/results/clientpositive/spark/bucket_map_join_tez2.q.out > 3ce67e22aa > ql/src/test/results/clientpositive/spark/bucketmapjoin4.q.out 2b384b7f7f > ql/src/test/results/clientpositive/spark/bucketmapjoin_negative3.q.out > c1341d926a > ql/src/test/results/clientpositive/spark/smb_mapjoin_1.q.out ecd7f2d1a6 > ql/src/test/results/clientpositive/spark/smb_mapjoin_2.q.out da419fe384 > ql/src/test/results/clientpositive/spark/smb_mapjoin_25.q.out e9e837f0d5 > ql/src/test/results/clientpositive/spark/smb_mapjoin_3.q.out 9362085dc6 > ql/src/test/results/clientpositive/spark/smb_mapjoin_4.q.out 42161fee06 > ql/src/test/results/clientpositive/spark/smb_mapjoin_5.q.out 9d1b9df017 > ql/src/test/results/clientpositive/udaf_percentile_approx_23.q.out > ed45f6460b > > > Diff: https://reviews.apache.org/r/65009/diff/2/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
