----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65002/#review194926 -----------------------------------------------------------
ql/src/test/results/clientpositive/llap/resourceplan.q.out Line 4051 (original), 4055 (patched) <https://reviews.apache.org/r/65002/#comment274011> This should be def.c1, most likely the poolOrUnmanaged changed the tree structure when poolPath was expected. standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 10474 (patched) <https://reviews.apache.org/r/65002/#comment274012> Should we support unmanged in alter mapping? Can someone change a mapping from managed to unmanaged? Currently, if pool is null, there is no update. We cannot set pool to null with the alter, but a mapping with null pool can be changed to have a pool. I suppose we should prevent that too. Should we throw an error informing that mapping cannot change from managed to unmanaged and vice versa. - Harish Jaiprakash On Jan. 6, 2018, 8:55 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65002/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2018, 8:55 a.m.) > > > Review request for hive and Harish Jaiprakash. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 59bef52b74 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > c413bc5126 > ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g 1b051f2e58 > ql/src/test/queries/clientpositive/resourceplan.q ce684ed51b > ql/src/test/results/clientpositive/llap/resourceplan.q.out 29c01a8b43 > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 5bfa62485b > > > Diff: https://reviews.apache.org/r/65002/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
