-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64925/#review194713
-----------------------------------------------------------




standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 1635 (patched)
<https://reviews.apache.org/r/64925/#comment273644>

    looks like this success boolean is not tracking success of commit.
    Exception is already being thrown from above stack.


- Thejas Nair


On Jan. 3, 2018, 8:09 p.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64925/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 8:09 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-18349
>     https://issues.apache.org/jira/browse/HIVE-18349
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-18349: Misc metastore changes for debuggability
> 
> 
> Diffs
> -----
> 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
>  f1b58c526db15cfdf9098af603549643c0f4dd13 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  2e43dc85eae2490683a52444c9456e201697a3b3 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
>  4ff2bb77d387bd2182f8cdd248303edd15dd12bd 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java
>  6ffc24a27a452f9a063831a2a1d39a7b1be5d6b5 
> 
> 
> Diff: https://reviews.apache.org/r/64925/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Reply via email to