----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64222/#review192749 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java Lines 1353 (patched) <https://reviews.apache.org/r/64222/#comment271005> hmm.. several returns will overwrite each others events. Perhaps addTerminal... should be changed to return the current event if already set, similar to the one that dumps state. Why is this needed anyway? - Sergey Shelukhin On Dec. 3, 2017, 10:40 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64222/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2017, 10:40 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-18088 > https://issues.apache.org/jira/browse/HIVE-18088 > > > Repository: hive-git > > > Description > ------- > > HIVE-18088: Add WM event traces at query level for debugging > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3be5a8d > itests/hive-unit/pom.xml ea5b7b9 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractJdbcTriggersTest.java > 235e6c3 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersMoveWorkloadManager.java > a983855 > ql/src/java/org/apache/hadoop/hive/ql/Context.java 97b52b0 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 389a1a6 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java 0509cbc > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KillMoveTriggerActionHandler.java > 94b189b > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/KillTriggerActionHandler.java > 8c60b6f > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 6fa3724 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java af77f30 > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TriggerValidatorRunnable.java > 5821659 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmEvent.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java d61c531 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java ecdcf12 > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java > 0a9fa72 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/PrintSummary.java > 5bb6bf1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java > 3dd4b31 > > ql/src/java/org/apache/hadoop/hive/ql/hooks/PostExecWMEventsSummaryPrinter.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/wm/Trigger.java e41b460 > ql/src/java/org/apache/hadoop/hive/ql/wm/TriggerActionHandler.java 8b142da > ql/src/java/org/apache/hadoop/hive/ql/wm/TriggerContext.java 16072c3 > ql/src/java/org/apache/hadoop/hive/ql/wm/WmContext.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java > 78df962 > > > Diff: https://reviews.apache.org/r/64222/diff/3/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
