----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63927/#review191431 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java Line 2124 (original), 2126 (patched) <https://reviews.apache.org/r/63927/#comment269248> Not all versions of orc has hasNull flag in proto. So hasHasNull has to be verified before .hasNull()? If it doesn't have hasNull flag it will just return false which is wrong as it may or may not have nulls. - Prasanth_J On Nov. 18, 2017, 1:24 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63927/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2017, 1:24 a.m.) > > > Review request for hive, Jason Dere and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > c32f79fe95 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 599b5191c6 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestIncrementalObjectSizeEstimator.java > 1ec702011a > pom.xml 04fb7c3c55 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 1e5b841f4b > ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java cbbbb150b6 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 80b7be8e5a > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java d2bb6417a2 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java > a916d58f3e > ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicValue.java a20328cb69 > > > Diff: https://reviews.apache.org/r/63927/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
